-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect average nthreads in adaptive #8041
Conversation
Previously we would assume in adaptive that workers had a single core. Now we do a pass through all the workers to sum up the number of threads per machine and divide the recommendation by this amount. This is not very expensive ```python-console In [1]: class Worker: ...: def __init__(self): ...: self.cpu = 4 ...: In [2]: workers = [Worker() for _ in range(1000)] In [3]: %timeit sum(w.cpu for w in workers) 33.6 µs ± 170 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) ```
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 10h 37m 14s ⏱️ - 46m 54s For more details on these failures, see this check. Results for commit 2a2aedf. ± Comparison against base commit 9d9702e. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@fjetter handing this off to you and your team if you're cool with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hendrikmakait feel free to merge once the test works
Thank you both for getting this in. |
cc @dchudz , this is in. |
Previously we would assume in adaptive that workers had a single core.
Now we do a pass through all the workers to sum up the number of threads per machine and divide the recommendation by this amount.
This is not very expensive
Supercedes #8039