-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate for directive #738
base: analyzer-element2
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: source_gen | ||
version: 2.0.0-wip | ||
version: 2.0.0 | ||
description: >- | ||
Source code generation builders and utilities for the Dart build system | ||
repository: https://github.com/dart-lang/source_gen/tree/master/source_gen | ||
|
@@ -10,10 +10,10 @@ environment: | |
sdk: ^3.6.0 | ||
|
||
dependencies: | ||
analyzer: ^6.9.0 | ||
analyzer: '>=6.9.0 <8.0.0' | ||
async: ^2.5.0 | ||
build: ^2.1.0 | ||
dart_style: ^2.3.7 | ||
dart_style: '>=2.3.7 <4.0.0' | ||
glob: ^2.0.0 | ||
path: ^1.8.0 | ||
pub_semver: ^2.1.4 | ||
|
@@ -29,7 +29,8 @@ dev_dependencies: | |
test: ^1.16.0 | ||
|
||
dependency_overrides: | ||
analyzer: ^7.1.0 | ||
analyzer: | ||
path: /Users/scheglov/Source/Dart/sdk.git/sdk/pkg/analyzer | ||
build: | ||
git: | ||
url: https://github.com/dart-lang/build.git | ||
Comment on lines
31
to
36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should just delete this section, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, definitely need to use an actual published analyzer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I don't see any objections, so I will move forward with publishing the required analyzer version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Uh...I haven't had time to reason about this change yet, honestly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is ETA for reviewing this? |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the deal w/ this @scheglov ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, i don't understand the question.
This method is invoked at the line
62
.We cannot use the same method for elements and directive.