Generate for directive #738
Conversation
|
@scheglov – needs to do some tweaks here, it appears. |
| dependency_overrides: | ||
| analyzer: ^7.1.0 | ||
| analyzer: | ||
| path: /Users/scheglov/Source/Dart/sdk.git/sdk/pkg/analyzer | ||
| build: | ||
| git: | ||
| url: https://github.com/dart-lang/build.git |
There was a problem hiding this comment.
Should just delete this section, right?
There was a problem hiding this comment.
Oh, definitely need to use an actual published analyzer.
I need to know if the general approach looks good to you.
If it is, I will publish the analyzer, and update the dependency.
There was a problem hiding this comment.
OK, I don't see any objections, so I will move forward with publishing the required analyzer version.
https://dart-review.googlesource.com/c/sdk/+/403264
There was a problem hiding this comment.
Uh...I haven't had time to reason about this change yet, honestly.
There was a problem hiding this comment.
What is ETA for reviewing this?
| /// | ||
| /// Implementations should return `null` when no content is generated. Empty | ||
| /// or whitespace-only [String] instances are also ignored. | ||
| dynamic generateForAnnotatedDirective( |
There was a problem hiding this comment.
What's the deal w/ this @scheglov ?
There was a problem hiding this comment.
I'm sorry, i don't understand the question.
This method is invoked at the line 62.
We cannot use the same method for elements and directive.
Continue #735
Note that it restores
applies to annotated directivestest, as discussed in the previous PR.This functionality is indeed used, by
package:checksgenerator.The first version uses
analyzerdependency override, because I want want you to look at the code before I publishanalyzer.