Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [ffigen] Retain bug repro #1973

Closed
wants to merge 2 commits into from
Closed

WIP: [ffigen] Retain bug repro #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea800ca
Repro the bug
liamappelbe Feb 6, 2025
c26319a
Run on the other mac architecture
liamappelbe Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ffigen_weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,18 @@
name: ffigen_weekly

on:
# Run once a week.
push:
branches: [main, stable]
paths:
- '.github/workflows/ffigen_weekly.yml'
- '.github/workflows/ffigen.yml'
- 'pkgs/ffigen/**'
- 'pkgs/objective_c/**'
pull_request:
branches: [main, stable]
paths:
- '.github/workflows/ffigen_weekly.yml'
schedule:
- cron: "0 0 * * 0"
- '.github/workflows/ffigen.yml'
- 'pkgs/ffigen/**'
- 'pkgs/objective_c/**'

env:
PUB_ENVIRONMENT: bot.github
Expand Down
2 changes: 1 addition & 1 deletion pkgs/ffigen/test/native_objc_test/setup.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const arcDisabledFiles = <String>{
};

Future<void> _runClang(List<String> flags, String output) async {
final args = [...flags, '-o', output];
final args = [...flags, '-Ofast', '-o', output];
final process = await Process.start('clang', args);
unawaited(stdout.addStream(process.stdout));
unawaited(stderr.addStream(process.stderr));
Expand Down
1 change: 1 addition & 0 deletions pkgs/objective_c/test/setup.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ String _resolve(String file) => _pkgDir.resolve(file).toFilePath();
void _runClang(List<String> flags, String output) {
final args = [
...flags,
'-Ofast',
'-o',
output,
];
Expand Down
Loading