Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [ffigen] Retain bug repro #1973

Closed
wants to merge 2 commits into from
Closed

WIP: [ffigen] Retain bug repro #1973

wants to merge 2 commits into from

Conversation

liamappelbe
Copy link
Contributor

No description provided.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:ffigen package:objective_c labels Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 4.1.0 5.0.0-wip 5.0.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Feb 6, 2025

Coverage Status

coverage: 87.382% (-0.6%) from 87.936%
when pulling c26319a on retain_bug_repro
into 3f07a8f on main.

@liamappelbe liamappelbe closed this Feb 6, 2025
@liamappelbe liamappelbe deleted the retain_bug_repro branch February 6, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ffigen package:objective_c type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants