Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing a nullable value to Future<nn-type>.value #3567

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Avoid passing a nullable value to Future<nn-type>.value #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f14d4f
Avoid passing a nullable value to Future<nn-type>.value
srawlins Aug 31, 2023
882c812
update pubspec/changelog
jakemac53 Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_test/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.2.1-dev

- Avoid passing a nullable value to `Future.value`.

## 2.2.0

- Forward logs from `testBuilder` to `printOnFailure` by default.
Expand Down
2 changes: 1 addition & 1 deletion build_test/lib/src/written_asset_reader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class WrittenAssetReader extends MultiPackageAssetReader {
if (!source.assets.containsKey(id)) {
throw AssetNotFoundException(id);
}
return Future.value(source.assets[id]);
return Future.value(source.assets[id]!);
}

@override
Expand Down
2 changes: 1 addition & 1 deletion build_test/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: build_test
description: Utilities for writing unit tests of Builders.
version: 2.2.0
version: 2.2.1-dev
repository: https://github.com/dart-lang/build/tree/master/build_test

environment:
Expand Down
Loading