Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing a nullable value to Future<nn-type>.value #3567

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Avoid passing a nullable value to Future<nn-type>.value #3567

merged 2 commits into from
Sep 1, 2023

Commits on Aug 31, 2023

  1. Avoid passing a nullable value to Future<nn-type>.value 

    This is cleanup work required to start enforcing this with static analysis, as per dart-lang/sdk#53253.

Real quick this issue is that this code is unsafe:

```dart
void f(Completer<int> c, int? i) {
  Future<int>.value(i); // Ouch!
  c.complete(i);        // Ouch!
}
```
    @srawlins
    srawlins authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5f14d4f View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. update pubspec/changelog

    @jakemac53
    jakemac53 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    882c812 View commit details
    Browse the repository at this point in the history