Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licensing on -derive repo #590

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fix licensing on -derive repo #590

merged 4 commits into from
Oct 31, 2023

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Oct 29, 2023

The curve25591-dalek-derive repo is just a vendored copy of unsafe_target_feature (see #531). As such I have copied over those license files.

@rozbb
Copy link
Contributor Author

rozbb commented Oct 29, 2023

@koute it appears that there is no copyright line on either of these files (here or in your repo). Would you like to add a copyright line crediting yourself? Let me know what to write.

@koute
Copy link
Contributor

koute commented Oct 30, 2023

@koute it appears that there is no copyright line on either of these files (here or in your repo). Would you like to add a copyright line crediting yourself? Let me know what to write.

I usually don't add explicit copyright lines since legally it makes no difference and practically it's mostly useless (unless you're going to add every contributor, in which case it can act as a list of everyone who has copyright over a given work, although that's kinda redundant if you have the git history) and can sometimes be a bad idea, but if you do want to add an explicit copyright line feel free to use the name of my employer: Parity Technologies (UK) Ltd.

@rozbb
Copy link
Contributor Author

rozbb commented Oct 30, 2023

Understood, thank you for the quick response. I have no strong desire to include a copyright line, so we can just leave it how it is.

@rozbb
Copy link
Contributor Author

rozbb commented Oct 31, 2023

Quick note: the build warnings I was getting were becausefield.rs had unused pub use statements, but the module itself is only pub(crate). They're vestigial, it seems. Now the module is all pub(crate)

@rozbb rozbb merged commit f4cd43f into main Oct 31, 2023
44 checks passed
@rozbb rozbb deleted the derive-license branch October 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants