Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing author info and license files for curve25519-dalek-derive #589

Closed
alexanderkjall opened this issue Oct 28, 2023 · 9 comments
Closed

Comments

@alexanderkjall
Copy link

The readme file refers to license files that gives 404's here:

https://github.com/dalek-cryptography/curve25519-dalek/blob/main/curve25519-dalek-derive/README.md?plain=1#L189

Could I assume that the authors are the same as curve25519-dalek when packaging this for Debian?

@rozbb
Copy link
Contributor

rozbb commented Oct 29, 2023

Good catch. I think it would be the people who contributed the crate. I'll make that PR and clarify things

@rozbb
Copy link
Contributor

rozbb commented Oct 30, 2023

Update: the license files will be moved into the repo in #590

@rozbb
Copy link
Contributor

rozbb commented Oct 31, 2023

Merged that PR. License files are now there. They don't have any copyright lines bc the author waived it. Feel free to reopen if this doesn't answer your question

@rozbb rozbb closed this as completed Oct 31, 2023
@tarcieri
Copy link
Contributor

Perhaps we should cut another crate release that includes these files?

@alexanderkjall
Copy link
Author

It's not needed for my use case, but I'm still a bit unsure what I should document as copyright holders for the crate.

Would 'RustCrypto Developers' be good?

@rozbb
Copy link
Contributor

rozbb commented Oct 31, 2023

How necessary is it to name a specific person? It seems like the field is freeform. So would Copyright 2023 work? I say this because I don't want to misrepresent the origin of the file, and placing "RustCrypto Developers" after a nonexistent copyright line is indistinguishable from claiming the whole thing was made by RustCrypto developers

@tarcieri
Copy link
Contributor

You could say "Dalek Developers"

@alexanderkjall
Copy link
Author

So copyright isn't about who created a piece of work, it rather about documenting who owns the copyright of the thing.

The reason I ask is that I don't fully understand what it means to "waive" ones copyright, I presumed it meant that they transferred their copyright to someone else, maybe to the group of developers who have built these crates, aka the RustCrypto Developers.

In a hypothetical scenario: If there was a pressing need to relicense this work under another license, who could do that?

@tarcieri
Copy link
Contributor

@koute is the principal author of curve25519-dalek-derive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants