Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from brl: to a11y: prefix for metadata properties #216

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

mattgarrish
Copy link
Contributor

In addition to renaming the properties and updating the section on referencing them, I've also removed all the problematic compatibility notes about brl: not being an epub reserved prefix.

Note that this doesn't change the naming of any existing properties or add any new ones. We should tackle those as separate issues.

Fixes #215

Copy link
Collaborator

@clapierre clapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to start, but some items may need further refinement where just having a11y:xyz won't make sense such as a11y:cellType here I would think a11y:brailleCellType.

@mattgarrish
Copy link
Contributor Author

mattgarrish commented Jul 3, 2024

Ya, it's easy to get into bikeshedding names with metadata which is why it'd be better to open separate issues for each name that could be changed. I'll reopen #194 as that was already about picking a better name and led to cellType.

@GeorgeKerscher
Copy link
Collaborator

I think this looks right, swaping in the A11y prefix.

@mattgarrish
Copy link
Contributor Author

I found epubcheck doesn't like additional properties while creating the sample, but not sure why. I don't think it verifies any other vocabularies to make sure properties exist.

In any case, that's a minor technicality as we need an updated validator regardless of what we define.

@mattgarrish mattgarrish merged commit 760a1f4 into main Jul 8, 2024
@mattgarrish mattgarrish deleted the metadata/prefix branch July 8, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch brl: prefix to a11y:
4 participants