Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename brl:dotNumber to brl:cellType #194

Closed
egli opened this issue Jun 25, 2024 · 4 comments · Fixed by #304
Closed

Rename brl:dotNumber to brl:cellType #194

egli opened this issue Jun 25, 2024 · 4 comments · Fixed by #304
Labels
eBraille specification Issue for the ebraille 1.0 specification Topic - metadata Issue with the package document metadata

Comments

@egli
Copy link
Member

egli commented Jun 25, 2024

Makes the intention behind the field more clear
@egli egli added the Topic - metadata Issue with the package document metadata label Jun 25, 2024
@wfree-aph wfree-aph mentioned this issue Jun 27, 2024
Closed
@mattgarrish mattgarrish mentioned this issue Jun 29, 2024
Merged
@mattgarrish
Copy link
Contributor

Closing this issue as the name change was included in #209

@mattgarrish mattgarrish mentioned this issue Jul 3, 2024
Merged
@mattgarrish
Copy link
Contributor

Reopening this because of the proposed change of prefix from brl: to a11y: in #216

The question is whether the property still makes sense without a braille sounding prefix to it.

@mattgarrish mattgarrish reopened this Jul 3, 2024
@mattgarrish mattgarrish added the eBraille specification Issue for the ebraille 1.0 specification label Sep 27, 2024
@wfree-aph
Copy link
Collaborator

@mattgarrish It seems like it doesn't really make sense without the braille association in the prefix. Could it be changed to a11y:braillecelltype?

@mattgarrish
Copy link
Contributor

Yes. The only thing I'd suggest differently is to keep the camel case naming we use for the other properties, so make it a11y:brailleCellType

@mattgarrish mattgarrish mentioned this issue Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eBraille specification Issue for the ebraille 1.0 specification Topic - metadata Issue with the package document metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename cellType to brailleCellType daisy/ebraille
3 participants
@egli @mattgarrish @wfree-aph