-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] InputDefinition
#26683
Draft
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_create_external_assets_from_specs_
Choose a base branch
from
12-23-_core-api_experimental_inputdefinition_
base: 12-23-_core-api_experimental_create_external_assets_from_specs_
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[core-api][experimental] InputDefinition
#26683
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_create_external_assets_from_specs_
from
12-23-_core-api_experimental_inputdefinition_
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
December 23, 2024 21:54
7b11644
to
e56c48e
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_inputdefinition_
branch
from
December 23, 2024 21:54
675e3ca
to
6e9286c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental params -> superseded
reason: InputDefinition is a very old API that does not really exist in modern-day dagster. explicitly categorizing params for such an old API as experimental seems wasteful, so I just marked the entire class as superseded
docs exist: n/a
How I Tested These Changes
Changelog