-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PM and MM #39
Conversation
Thanks @talonchandler, I think this will be good, we'll test and merge soon |
I find that when using TODO: update the readme to reflect the correct MM version |
Sounds good, MM recommendation fixed. Feel free to merge when you're ready. |
I ran into a bug with the mantis acquisition that I'm trying to trace down before merging this PR. If the bug is in the java AnqEngJ then we'll need to upgrade to a newer PM version after I fix it. |
We'll need to upgrade to the latest pycromanager and MM nightly build after micro-manager/AcqEngJ#94 and micro-manager/pycro-manager#623 get merged. |
@talonchandler @edyoshikun this PR is ready to merge, pending one more test on the microscope. Can I get a quick review of the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. The most important change I think was the iohub to 0.1.0.dev4
for making sure that the datasets created have the proper dtype
and LUT when loaded into napari, and the pycromanager version which is the one on mantis at the moment. Thanks guys!
Thanks! As far as the acquisition goes, there is no real dependency on |
LGTM, thanks Ivan. |
Before this PR, the mantis acquisition used MM nightly build 2023-02-08 with NDTiffStorage 2.10.0 for the LF acquisition and MM nightly build 2023-03-12 for the LS acquisition. A clone of the conda environment used before this PR is available as |
The current
pycromanager==0.25.40
is not compatible withrecOrder
, so this PR suggests an upgrade topycromanager==0.27.2
. See mehta-lab/recOrder#373.You might try upgrading pycromanager without upgrading MM, but I expect you'll need to upgrade MM to 2023-04-26 at the same time. I've updated the docs to reflect this, but feel free to change.
These upgrades should be tested on the scope before merging.