Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save HCS position label in NDTiff dataset axes #70

Merged
merged 6 commits into from
Aug 19, 2023

Conversation

ieivanov
Copy link
Collaborator

@ieivanov ieivanov commented Jul 28, 2023

This PR enables using HCS position labels as indices of the NDTiff dataset "position" axis. This will allow us to parse them using iohub (czbiohub-sf/iohub#166) and propagate them to downstream processed results using infrastructure developed in czbiohub-sf/iohub#159.

Example datasets available in https://github.com/micro-manager/NDTiffStorage/pull/124/files and cm.automaton/mantis_HCS_acq_1

Closes #32.

Requires micro-manager/AcqEngJ#95 and #39

This PR should be used with caution until micro-manager/NDStorage#124 is resolved. Using iohub to read the data is robust to sorting issues discussed in that PR.

EDIT: micro-manager/NDStorage#124 has merged. iohub is also robust to reading data with unordered position labels.

Other related PRs: micro-manager/AcqEngJ#95, micro-manager/pycro-manager#640

@ieivanov ieivanov marked this pull request as ready for review July 29, 2023 01:02
@ziw-liu
Copy link
Contributor

ziw-liu commented Aug 5, 2023

I'm a bit confused, czbiohub-sf/iohub#166 requires ndtiff>2.2.1, but c07ad15 requires ndtiff<2.0?

@ieivanov
Copy link
Collaborator Author

ieivanov commented Aug 5, 2023

I'm a bit confused, czbiohub-sf/iohub#166 requires ndtiff>2.2.1, but c07ad15 requires ndtiff<2.0?

Right, this is a temporary restriction until #39 merges, hopefully very soon

@ieivanov
Copy link
Collaborator Author

@talonchandler @edyoshikun can I get a review on this PR? In summary it switches the position axis of mantis datasets from integers, e.g. [0, 1, 2], to strings, e.g. ['Pos0', 'Pos1', 'Pos2'] or more likely ['A1_Site0', 'A1_Site1', 'A1_Site2']. This is a simple change to the acquisition engine, but downstream processing of this data has been a bit more involved. After czbiohub-sf/iohub#171 merges we'll be in good shape to take these datasets and convert them to zarr, preserving the HCS site labels in the zarr store.

@talonchandler
Copy link
Contributor

LGTM! Nice inter-library metadata wrangling 🤠 .

Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This makes more sense. Thanks for this

@ziw-liu
Copy link
Contributor

ziw-liu commented Aug 18, 2023

Does this require iohub==0.1.0dev5?

@ieivanov ieivanov merged commit 8d49dd0 into main Aug 19, 2023
2 checks passed
@ieivanov ieivanov deleted the feature/save_position_label branch December 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write positions.csv log during acquisition
4 participants