-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save HCS position label in NDTiff dataset axes #70
Conversation
I'm a bit confused, czbiohub-sf/iohub#166 requires ndtiff>2.2.1, but c07ad15 requires ndtiff<2.0? |
Right, this is a temporary restriction until #39 merges, hopefully very soon |
@talonchandler @edyoshikun can I get a review on this PR? In summary it switches the position axis of mantis datasets from integers, e.g. |
LGTM! Nice inter-library metadata wrangling 🤠 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This makes more sense. Thanks for this
Does this require iohub==0.1.0dev5? |
This PR enables using HCS position labels as indices of the NDTiff dataset "position" axis. This will allow us to parse them using iohub (czbiohub-sf/iohub#166) and propagate them to downstream processed results using infrastructure developed in czbiohub-sf/iohub#159.
Example datasets available in https://github.com/micro-manager/NDTiffStorage/pull/124/files and
cm.automaton/mantis_HCS_acq_1
Closes #32.
Requires micro-manager/AcqEngJ#95 and #39This PR should be used with caution until micro-manager/NDStorage#124 is resolved. Usingiohub
to read the data is robust to sorting issues discussed in that PR.EDIT: micro-manager/NDStorage#124 has merged.
iohub
is also robust to reading data with unordered position labels.Other related PRs: micro-manager/AcqEngJ#95, micro-manager/pycro-manager#640