Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix t_idx and additional channels #134

Merged
merged 17 commits into from
Jul 2, 2024
Merged

Fix t_idx and additional channels #134

merged 17 commits into from
Jul 2, 2024

Conversation

edyoshikun
Copy link
Contributor

WIP: fixes the t_idx issue from ....

@ziw-liu ziw-liu added bug Something isn't working analysis Software development needed for data analysis labels Feb 22, 2024
@ziw-liu ziw-liu linked an issue Feb 22, 2024 that may be closed by this pull request
Cannot apply affine transform #133
Closed
@ieivanov
Copy link
Collaborator

@edyoshikun I am looking at the utils.py diff and it seems you haven't started from the latest main branch? Can you check on this and update the code as needed so it's easier to see the changes you introduced?

@edyoshikun
Copy link
Contributor Author

@ieivanov updated.

ieivanov
ieivanov requested changes Jun 28, 2024
View reviewed changes
mantis/analysis/register.py Outdated Show resolved Hide resolved
mantis/cli/apply_affine.py Outdated Show resolved Hide resolved
mantis/cli/estimate_affine.py Outdated Show resolved Hide resolved
mantis/cli/estimate_affine.py Outdated Show resolved Hide resolved
mantis/cli/estimate_affine.py Outdated Show resolved Hide resolved
mantis/cli/utils.py Outdated Show resolved Hide resolved
@edyoshikun
ruff flake8
0f47090
@edyoshikun
- fixing bug when source and target channels are the same.
f0ae5ee 
- removing extra parameters not used
-support for 2D and 3D
-renaming flag for similarity-> similarity
@edyoshikun
adding notes for the Z LIR estimation. Note: this assumes the center …
c5f580b 
…is representative of volume's LIR.
@ieivanov ieivanov mentioned this pull request Jul 1, 2024
Closed
11 tasks
@ieivanov ieivanov marked this pull request as ready for review July 1, 2024 23:56
@edyoshikun edyoshikun merged commit bd7814c into main Jul 2, 2024
2 checks passed
@talonchandler talonchandler deleted the fix_apply_affine branch July 11, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ieivanov ieivanov ieivanov approved these changes

Assignees
No one assigned
Labels
analysis Software development needed for data analysis bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot apply affine transform
3 participants
@edyoshikun @ieivanov @ziw-liu