cursorCleared: remove asyncFocus

[ethan-james]

Fixes #2705

Calling asyncFocus() after clearThought triggers the editable's onBlur which dispatches cursorCleared({ value: false }), which undoes the whole clearThought operation.

Without asyncFocus(), clearThought can proceed as intended.

asyncFocus() was triggered on any clearThought, and the reason why it's failing in this specific case is because selection.isText() return true on a basic clearThought, and false after cursorForward. The reason for this is because the native selection sets focusNode to the text node within the editable, while cursorForward is setting focusNode to the editable div.

[ethan-james]

I guess this is the same fix from #2752 that is already captured in #2753.

In this case, the steps to reproduce that bad focus behavior are:

1. clearThought gesture on the active cursor
2. Close the keyboard
3. clearThought gesture again
4. Keyboard doesn't open

[raineorshine]

Thanks so much for the clear explanation. It looks like I have been a bit too liberal with asyncFocus! It works great when there is no focus, but causes problems if the editable already has the focus, and it definitely doesn't work well with clearThought.

The provided solution works great.

[ethan-james]

Right on, I tested it when there is no focus and it seemed OK. I know asyncFocus is in there to solve a problem, but I couldn't find any case that would break without it here.

I'd still like to figure out why the selection.isText() thing is breaking, but like I say, I didn't see any example where leaving asyncFocus in would improve things.

[raineorshine]

Yep. It's possible we might be able to implement a more general fix, but I've opened #2753 for that.