Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection.set does not always open keyboard #2753

Open
raineorshine opened this issue Jan 4, 2025 · 0 comments
Open

selection.set does not always open keyboard #2753

raineorshine opened this issue Jan 4, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Jan 4, 2025

The goal of this issue is to:

  • Determine what is wrong with selection.set and why focus() is needed (if possible).
  • Determine if it is safe to move the focus() call into selection.set.
  • Remove focus() from useEditMode to restore the invariant that all selection behavior occurs via the selection module.

I'm not quite sure why this is necessary, but it was having the following problem on iOS Safari:

  1. Tap a thought - cursor moves, keyboard stays closed

  2. Tap it again - keyboard opens

  3. Close keyboard

  4. Tap it again - keyboard does not open

Originally posted by @ethan-james in #2752 (comment)

@raineorshine raineorshine added the bug Something isn't working label Jan 4, 2025
@raineorshine raineorshine added this to the 🏹 Browser Selection milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant