Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new team names #463

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Support new team names #463

merged 1 commit into from
Sep 5, 2023

Conversation

dtcarls
Copy link
Contributor

@dtcarls dtcarls commented Sep 5, 2023

Fixes #462

@dtcarls dtcarls mentioned this pull request Sep 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.03% ⚠️

Comparison is base (81f8967) 80.36% compared to head (a1975e0) 80.34%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   80.36%   80.34%   -0.03%     
==========================================
  Files          60       60              
  Lines        2109     2111       +2     
==========================================
+ Hits         1695     1696       +1     
- Misses        414      415       +1     
Files Changed Coverage Δ
espn_api/football/team.py 98.55% <66.66%> (-1.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkirby528
Copy link

mkirby528 commented Sep 5, 2023

@cwendt94 any chance we could get this reviewed/merged before the start of the NFL season?

@cwendt94
Copy link
Owner

cwendt94 commented Sep 5, 2023

Yeah, I will have this in and publish changes today! Thanks for fixing this @dtcarls

@cwendt94 cwendt94 merged commit 8ed3355 into cwendt94:master Sep 5, 2023
1 check passed
@cwendt94
Copy link
Owner

cwendt94 commented Sep 5, 2023

@dtcarls @mkirby528 This fix should now be in version 0.31.0 pip install espn-api==0.31.0

@mkirby528
Copy link

Wonderful! Thank you both so much!

@dtcarls dtcarls mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team Names not correct
4 participants