Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Names not correct #462

Closed
stoller2122 opened this issue Sep 5, 2023 · 2 comments · Fixed by #463
Closed

Team Names not correct #462

stoller2122 opened this issue Sep 5, 2023 · 2 comments · Fixed by #463

Comments

@stoller2122
Copy link

stoller2122 commented Sep 5, 2023

Sport

Football

Summary

Seems like ESPN changed the location + nickname format for team names this year in fantasy football. Only a single team "name" now for team names. Output for each team is "Team" + . This is an issue for a family league where everyone has the same last name.

*Edit: This issue only impacts a team newly created this year (2023) with team names updated this year. Seems like an old league (no team names updated this year) displays the expected team names.

Updating line 8 in team.py
from: self.team_name = "%s %s" % (data['location'], data['nickname'])
to: self.team_name = data['name'])

Logs/Data

Pulling data for a newly created 2023 league gave me following output for league.teams
[Team(Team Smith), Team(Team Smith), Team(Team Smith), Team(Team Smith), Team(Team Smith), Team(Team Smith), Team(Team Smith), Team(Team Smith)]

After updating the module with fix from above I now get the following output for league.teams
[Team(Cee Dee), Team(The Newts), Team(ÑFL), Team(So Hard), Team(Beavers), Team(Pabst Blue Ribbon), Team(The Bois), Team(Kyler Murray)]

@dtcarls
Copy link
Contributor

dtcarls commented Sep 5, 2023

I was able to replicate the issue. Thank you the details. #463 submitted as a fix.

@mkirby528
Copy link

Thanks for making this change! Was also running into the same issue and glad you found a fix! Hoping we can get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants