Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated xml queries to new parser #2073

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Migrated xml queries to new parser #2073

merged 10 commits into from
Dec 1, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Nov 29, 2023

Parsed using:
https://github.com/ObserverOfTime/tree-sitter-xml

Still have a problem where <?xml version="1.1" encoding="UTF-8" ?> fails. Even though the parser library has these in their own ci tests. Going to have to do some more testing

https://github.com/pokey/tree-sitter-wasm-test

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but see my comments on #2044; same apply here

@AndreasArvidsson
Copy link
Member Author

Start and end tag added

Base automatically changed from html_scopes to main November 30, 2023 18:31
@pokey pokey enabled auto-merge December 1, 2023 15:11
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pokey pokey added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 4a22005 Dec 1, 2023
13 checks passed
@pokey pokey deleted the xml branch December 1, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants