Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper xml support #858

Closed
pokey opened this issue Jul 11, 2022 · 2 comments
Closed

Proper xml support #858

pokey opened this issue Jul 11, 2022 · 2 comments
Labels
bug Something isn't working code quality Improvements to code quality enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jul 11, 2022

Currently, we just try to use the html parser for xml. That works some of the time, but is not very consistent. We should use a proper tree-sitter-xml. The only one I found was https://github.com/unhammer/tree-sitter-xml
@pokey pokey added bug Something isn't working enhancement New feature or request code quality Improvements to code quality labels Jul 11, 2022
@pokey
Copy link
Member Author

pokey commented Nov 29, 2023

See also cursorless-dev/vscode-parse-tree#49

@AndreasArvidsson
Copy link
Member

We now use a proper xml parser since: #2073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code quality Improvements to code quality enhancement New feature or request
Projects
A bit of polish
Status: Done
Expand the vocabulary
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pokey @AndreasArvidsson