Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope info provider #1941

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Scope info provider #1941

merged 2 commits into from
Oct 30, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Oct 12, 2023 •
edited
Loading

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey mentioned this pull request Oct 12, 2023
Merged
6 tasks
@pokey pokey force-pushed the pokey/scope-info-provider branch from c9fe1a3 to 3b17e39 Compare October 12, 2023 17:41
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from c4e7b75 to 6a6d06a Compare October 16, 2023 15:02
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 887c7df to 82a8ef5 Compare October 16, 2023 15:29
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from 6cc1055 to 6be3705 Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/scope-info-provider branch from 074ddf4 to 33ce2a2 Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 88d7ec1 to 84d2f1d Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/scope-info-provider branch from ceaf377 to 1c6435b Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from dfba742 to 36bcc86 Compare October 17, 2023 13:55
@pokey pokey force-pushed the pokey/scope-info-provider branch from 7b220c3 to 0c5e9b3 Compare October 17, 2023 13:55
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 60a927f to c07368a Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/scope-info-provider branch from 3c5d883 to 962f921 Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 07562d7 to 2e509b7 Compare October 18, 2023 15:07
@pokey pokey force-pushed the pokey/scope-info-provider branch from d80a73f to 9f61dd8 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 2e509b7 to 983ebe2 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/scope-info-provider branch from 9f61dd8 to 709fb57 Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 983ebe2 to 516045d Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/scope-info-provider branch from 709fb57 to d995f40 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 516045d to e71eb95 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/scope-info-provider branch from d995f40 to a977bf0 Compare October 20, 2023 12:45
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 3abd5af to 896bbe4 Compare October 20, 2023 13:00
@pokey pokey force-pushed the pokey/scope-info-provider branch from a977bf0 to 49c3931 Compare October 20, 2023 13:00
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 896bbe4 to c9f226b Compare October 20, 2023 13:07
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 2f3d43e to 156ff94 Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from bdcc34e to 0979cba Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/scope-info-provider branch from beadd68 to 156ff94 Compare October 20, 2023 13:38
@pokey pokey marked this pull request as ready for review October 25, 2023 14:42
@pokey
Copy link
Member Author

pokey commented Oct 25, 2023 •
edited
Loading

Ok @AndreasArvidsson this one is ready too; let's wait to merge because it depends on #1940

@pokey pokey force-pushed the base/pokey/scope-info-provider branch from 61e18e0 to cb22980 Compare October 26, 2023 16:29
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 0f5bd0d to 8df8047 Compare October 26, 2023 16:31
@pokey pokey force-pushed the base/pokey/scope-info-provider branch from 17f1bb0 to 67149ce Compare October 26, 2023 16:37
@pokey pokey force-pushed the pokey/scope-info-provider branch from 8df8047 to 223fc7e Compare October 26, 2023 16:37
@pokey pokey force-pushed the pokey/scope-info-provider branch from 223fc7e to 67f8ce3 Compare October 27, 2023 10:57
@pokey pokey mentioned this pull request Oct 27, 2023
Closed
26 tasks
@pokey pokey force-pushed the base/pokey/scope-info-provider branch from 67149ce to 0c9a833 Compare October 29, 2023 17:28
@pokey pokey force-pushed the pokey/scope-info-provider branch from 67f8ce3 to 5820193 Compare October 29, 2023 17:28
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Get custom spoken forms from Talon (#1940)
cc155ba 
- This PR is the VSCode side of
#1939

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(tests added in #1941)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
@pokey pokey force-pushed the pokey/scope-info-provider branch from 5820193 to 26b5d39 Compare October 30, 2023 14:43
@pokey pokey changed the base branch from base/pokey/scope-info-provider to main October 30, 2023 14:43
@pokey pokey enabled auto-merge October 30, 2023 14:44
@pokey pokey added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 64d01e4 Oct 30, 2023
13 checks passed
@pokey pokey deleted the pokey/scope-info-provider branch October 30, 2023 15:34
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Cursorless scope side bar (#1942)
1260235 
- Depends on #1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this pull request Oct 30, 2023
@pokey @cursorless-bot
Cursorless scope side bar (#1942)
6c946c3 
- Depends on cursorless-dev/cursorless#1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
cursorless-bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Cursorless scope side bar (#1942)
bbc33e0 
- Depends on #1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Get custom spoken forms from Talon (cursorless-dev#1940)
0bb547a 
- This PR is the VSCode side of
cursorless-dev#1939

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(tests added in cursorless-dev#1941)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Scope info provider (cursorless-dev#1941)
26a7517 
- Depends on cursorless-dev#1940

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Cursorless scope side bar (cursorless-dev#1942)
df785cc 
- Depends on cursorless-dev#1941
- Depends on cursorless-dev#1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original cursorless-dev#1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pokey @AndreasArvidsson