Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursorless scope side bar #1942

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Cursorless scope side bar #1942

merged 2 commits into from
Oct 30, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Oct 12, 2023 •
edited
Loading

Checklist

  • [-] I have added tests (see comment below)
  • Add descriptions to section headings (eg present, not present, etc)
  • File issue about using lang icons for lang-specific scopes
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet
  • File issue for showing scopes touching, as well as equal to, selection
  • Checkboxes from original Scope support tree view #1663

This was referenced Oct 12, 2023
Merged
Merged
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from d0fcf1b to d5f310c Compare October 12, 2023 17:41
@pokey pokey force-pushed the pokey/scope-info-provider branch from c9fe1a3 to 3b17e39 Compare October 12, 2023 17:41
github-merge-queue bot pushed a commit that referenced this pull request Oct 13, 2023
@pokey
Expand scope visualizer api (#1946)
47cc724 
- Required by #1942 to be able to tell which scope is currently being
visualized to highlight it in the sidebar

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from c815e0d to 8cae134 Compare October 16, 2023 15:29
@pokey pokey force-pushed the pokey/scope-info-provider branch from 887c7df to 82a8ef5 Compare October 16, 2023 15:29
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 9b6a204 to abff9fb Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/scope-info-provider branch from ceaf377 to 1c6435b Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from c0a93d1 to 87cb21e Compare October 17, 2023 13:55
@pokey pokey force-pushed the pokey/scope-info-provider branch from 3c5d883 to 962f921 Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 6c86b5a to 103f385 Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/scope-info-provider branch from d80a73f to 9f61dd8 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from 1077cbd to b826f3e Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 709fb57 to d995f40 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from b826f3e to 3e8b231 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 3e8b231 to ebd6923 Compare October 20, 2023 12:45
@pokey pokey force-pushed the pokey/scope-info-provider branch from d995f40 to a977bf0 Compare October 20, 2023 12:45
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from f92a480 to 6e49a1c Compare October 20, 2023 13:07
@pokey pokey force-pushed the pokey/scope-info-provider branch from 49c3931 to 2f3d43e Compare October 20, 2023 13:07
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from fce6e07 to 3a4afaa Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/scope-info-provider branch from 2f3d43e to 156ff94 Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from d90b78a to 9f0780d Compare October 20, 2023 13:40
@pokey pokey mentioned this pull request Oct 27, 2023
Open
4 tasks
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 50b9626 to 82d8fc9 Compare October 27, 2023 10:57
@pokey pokey force-pushed the pokey/scope-info-provider branch from 223fc7e to 67f8ce3 Compare October 27, 2023 10:57
@pokey pokey mentioned this pull request Oct 27, 2023
Closed
26 tasks
@pokey
Copy link
Member Author

pokey commented Oct 27, 2023

Ok this one is also good to go @AndreasArvidsson; will need to merge in behind a couple others tho so please don't merge

@pokey pokey marked this pull request as ready for review October 27, 2023 11:04
@pokey
Copy link
Member Author

pokey commented Oct 27, 2023

I didn't add tests for this one, because most of the hard logic is tested in #1941. This one is trying hard to be pure presentation, and unfortunately testing it is quite hard until we have a setup where we delay initialisation of the extension to allow test harness to be put in place

@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 82d8fc9 to e2bd86d Compare October 29, 2023 17:28
@pokey pokey force-pushed the pokey/scope-info-provider branch from 67f8ce3 to 5820193 Compare October 29, 2023 17:28
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 4a334a7 to fdd5278 Compare October 30, 2023 14:43
@pokey pokey force-pushed the pokey/scope-info-provider branch from 5820193 to 26b5d39 Compare October 30, 2023 14:43
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from fdd5278 to 1169959 Compare October 30, 2023 15:05
Base automatically changed from pokey/scope-info-provider to main October 30, 2023 15:34
@pokey pokey force-pushed the pokey/cursorless-scope-side-bar branch from 1169959 to b44a7a5 Compare October 30, 2023 16:35
@pokey pokey enabled auto-merge October 30, 2023 16:36
@pokey pokey added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 1260235 Oct 30, 2023
13 checks passed
@pokey pokey deleted the pokey/cursorless-scope-side-bar branch October 30, 2023 17:05
cursorless-bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Cursorless scope side bar (#1942)
bbc33e0 
- Depends on #1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Live-updating regex scopes (#1943)
9730ac5 
- Depends on #1942

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Expand scope visualizer api (cursorless-dev#1946)
d689c5b 
- Required by cursorless-dev#1942 to be able to tell which scope is currently being
visualized to highlight it in the sidebar

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Cursorless scope side bar (cursorless-dev#1942)
df785cc 
- Depends on cursorless-dev#1941
- Depends on cursorless-dev#1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original cursorless-dev#1663
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Live-updating regex scopes (cursorless-dev#1943)
61696e8 
- Depends on cursorless-dev#1942

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@pokey @cursorless-bot
Cursorless scope side bar (cursorless-dev#1942)
6c946c3 
- Depends on cursorless-dev#1941
- Depends on cursorless-dev#1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original cursorless-dev#1663
@pokey pokey mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pokey @AndreasArvidsson