Add the scope visualizer #1653
Merged
Add the scope visualizer #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
Closed
Merged
Merged
pokey
force-pushed
the
base/pokey/add-the-scope-visualizer
branch
from
863e053 to
b8532c3
Compare
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
cb5a419 to
e8214db
Compare
pokey
commented
Jul 17, 2023
pokey
commented
Jul 17, 2023
pokey
commented
Jul 17, 2023
pokey
commented
Jul 17, 2023
packages/cursorless-vscode-e2e/src/suite/scopeVisualizer/runBasicMultilineContentTest.ts
Show resolved
Hide resolved
pokey
commented
Jul 17, 2023
packages/cursorless-vscode-e2e/src/suite/scopeVisualizer/runBasicMultilineContentTest.ts
Show resolved
Hide resolved
pokey
commented
Jul 17, 2023
pokey
commented
Jul 17, 2023
packages/cursorless-vscode/src/ide/vscode/VSCodeScopeVisualizer/VscodeScopeRenderer.ts
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
- Required by #1653 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
e8214db to
34ac721
Compare
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
34ac721 to
d8945f9
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Required by #1650 - Note that we have no tests here, but it is tested in #1653 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
AndreasArvidsson
approved these changes
Jul 18, 2023
pokey
force-pushed
the
base/pokey/add-the-scope-visualizer
branch
from
b8532c3 to
f85ff05
Compare
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
d8945f9 to
3aeb46a
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Required by #1653 - Depends on #1647 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
pokey
force-pushed
the
base/pokey/add-the-scope-visualizer
branch
from
f85ff05 to
e351a52
Compare
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
3aeb46a to
c1594c9
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Depends on #1648 - Depends on #1645 - Required by #1653 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Depends on #1650 - Depends on #1646 - Required by #1653 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
c1594c9 to
ccaab87
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Required by #1653 - Depends on #1651 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
pokey
force-pushed
the
pokey/add-the-scope-visualizer
branch
from
fc85ec0 to
91a25ae
Compare
cursorless-bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
- Depends on #1651 - Depends on #1652 - Depends on #1649 - Depends on #1644 ## Checklist - [x] Add image to doc page - [x] File issue to migrate all our vscode references to use new thin wrapper - [x] File issue about reworking removal highlight range to return generalised range, and not using line range for line target content range - [x] Investigate cheatsheet performance issue - [x] Migrate todos from #1523 - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have not broken the cheatsheet - [x] Compute border colors from background color? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
- Depends on cursorless-dev#1651 - Depends on cursorless-dev#1652 - Depends on cursorless-dev#1649 - Depends on cursorless-dev#1644 ## Checklist - [x] Add image to doc page - [x] File issue to migrate all our vscode references to use new thin wrapper - [x] File issue about reworking removal highlight range to return generalised range, and not using line range for line target content range - [x] Investigate cheatsheet performance issue - [x] Migrate todos from cursorless-dev#1523 - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have not broken the cheatsheet - [x] Compute border colors from background color? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopeRangeWatcher#1651ScopeSupportChecker#1652VscodeFancyRangeHighlighter#1649Checklist