Add ScopeRangeWatcher
#1651
Merged
Add ScopeRangeWatcher
#1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
- Required by #1651 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
AndreasArvidsson
approved these changes
Jul 18, 2023
pokey
force-pushed
the
pokey/add-scoperangewatcher
branch
from
0c2f322 to
b2ae87a
Compare
pokey
force-pushed
the
pokey/add-scoperangewatcher
branch
from
b2ae87a to
71c7bc7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Required by #1653 - Depends on #1651 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
- Depends on #1651 - Depends on #1652 - Depends on #1649 - Depends on #1644 ## Checklist - [x] Add image to doc page - [x] File issue to migrate all our vscode references to use new thin wrapper - [x] File issue about reworking removal highlight range to return generalised range, and not using line range for line target content range - [x] Investigate cheatsheet performance issue - [x] Migrate todos from #1523 - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have not broken the cheatsheet - [x] Compute border colors from background color? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot
pushed a commit
to cursorless-dev/cursorless-talon
that referenced
this pull request
Jul 19, 2023
- Depends on cursorless-dev/cursorless#1651 - Depends on cursorless-dev/cursorless#1652 - Depends on cursorless-dev/cursorless#1649 - Depends on cursorless-dev/cursorless#1644 ## Checklist - [x] Add image to doc page - [x] File issue to migrate all our vscode references to use new thin wrapper - [x] File issue about reworking removal highlight range to return generalised range, and not using line range for line target content range - [x] Investigate cheatsheet performance issue - [x] Migrate todos from #1523 - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have not broken the cheatsheet - [x] Compute border colors from background color? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
- Depends on #1651 - Depends on #1652 - Depends on #1649 - Depends on #1644 ## Checklist - [x] Add image to doc page - [x] File issue to migrate all our vscode references to use new thin wrapper - [x] File issue about reworking removal highlight range to return generalised range, and not using line range for line target content range - [x] Investigate cheatsheet performance issue - [x] Migrate todos from #1523 - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have not broken the cheatsheet - [x] Compute border colors from background color? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopeRangeProvider#1650Debouncer; use it forHatAllocator#1646Checklist