Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MatchTrue, MatchFalse and MatchCondition readiness checks #513

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

LCaparelli
Copy link
Contributor

Companion for crossplane/crossplane#4399

I noticed MatchCondition was not yet documented. If this was intentional or if you'd rather it in a separate PR just let me know :-)

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 0d4852b
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/64f10ebb0e605300087d7695
😎 Deploy Preview https://deploy-preview-513--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@plumbis plumbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you so much for the docs PR! A few nits to improve wording and pass Vale CI checks.

content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/master/concepts/compositions.md Outdated Show resolved Hide resolved
content/v1.13/concepts/compositions.md Outdated Show resolved Hide resolved
content/v1.13/concepts/compositions.md Outdated Show resolved Hide resolved
@LCaparelli
Copy link
Contributor Author

Ah thank you @plumbis, that's my bad, I forgot to run the checks locally 😅

I'll commit fixes shortly.

@phisco
Copy link
Collaborator

phisco commented Aug 25, 2023

@LCaparelli, gentle reminder 😅

@LCaparelli
Copy link
Contributor Author

@LCaparelli, gentle reminder 😅

Thanks hehe, just got back from vacation and this one escaped my final wrapping up process before disappearing 😁

@plumbis plumbis merged commit 02c676f into crossplane:master Sep 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants