Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pete Lumbis <[email protected]>
  • Loading branch information
LCaparelli and plumbis authored Aug 31, 2023
1 parent 969b94d commit 8bd7946
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
19 changes: 9 additions & 10 deletions content/master/concepts/compositions.md
Original file line number Diff line number Diff line change
Expand Up @@ -1132,14 +1132,14 @@ spec:
- type: None
```

#### Match a Condition
#### Match a condition
{{<hover label="condition" line="11">}}Condition{{</hover>}} considers the composed
resource to be ready when it finds the expected condition type, with the
expected status for it in its `status.conditions`.

For example, consider
{{<hover label="condition" line="7">}}my-resource{{</hover>}}, which will be marked
as ready if there is a condition of type
{{<hover label="condition" line="7">}}my-resource{{</hover>}}, which is
ready if there is a condition of type
{{<hover label="condition" line="13">}}MyType{{</hover>}} with a status of
{{<hover label="condition" line="14">}}Success{{</hover>}}.

Expand All @@ -1160,7 +1160,7 @@ spec:
status: Success
```

#### Match a Boolean
#### Match a boolean

Two types of checks exist for matching boolean fields:
* `MatchTrue`
Expand All @@ -1173,8 +1173,8 @@ field within that resource is `true`.
field within that resource is `false`.

For example, consider
{{<hover label="matchTrue" line="7">}}my-resource{{</hover>}}, which will be marked
as ready if
{{<hover label="matchTrue" line="7">}}my-resource{{</hover>}}, which is
ready if
{{<hover label="matchTrue" line="12">}} status.atProvider.manifest.status.ready{{</hover>}}
is {{<hover label="matchTrue" line="11">}}true{{</hover>}}.

Expand All @@ -1197,12 +1197,11 @@ Checking {{<hover label="matchTrue" line="11">}}MatchTrue{{</hover>}} doesn't
require a `match` field.
{{< /hint >}}

Alternatively, `MatchFalse` can be used for fields that express readiness with
negative polarity.
`MatchFalse` matches fields that express readiness with the value `false`.

For example, consider
{{<hover label="matchFalse" line="7">}}my-resource{{</hover>}}, which will be marked
as ready if
{{<hover label="matchFalse" line="7">}}my-resource{{</hover>}}, is
ready if
{{<hover label="matchFalse" line="12">}} status.atProvider.manifest.status.pending{{</hover>}}
is {{<hover label="matchFalse" line="11">}}false{{</hover>}}.

Expand Down
6 changes: 3 additions & 3 deletions content/v1.13/concepts/compositions.md
Original file line number Diff line number Diff line change
Expand Up @@ -1131,14 +1131,14 @@ spec:
- type: None
```

#### Match a Condition
#### Match a condition
{{<hover label="condition" line="11">}}Condition{{</hover>}} considers the composed
resource to be ready when it finds the expected condition type, with the
expected status for it in its `status.conditions`.

For example, consider
{{<hover label="condition" line="7">}}my-resource{{</hover>}}, which will be marked
as ready if there is a condition of type
{{<hover label="condition" line="7">}}my-resource{{</hover>}}, which is
ready if there is a condition of type
{{<hover label="condition" line="13">}}MyType{{</hover>}} with a status of
{{<hover label="condition" line="14">}}Success{{</hover>}}.

Expand Down

0 comments on commit 8bd7946

Please sign in to comment.