-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ARIA attributes to essential elements #232
Open
SisiVero
wants to merge
11
commits into
creativecommons:main
Choose a base branch
from
SisiVero:aria-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d46d9a9
addingg aria attributes
SisiVero c6fd06f
updated 404 page
SisiVero be867f1
Merge branch 'main' changes into aria-attributes
SisiVero e408c20
conflict resolved.
SisiVero 640d151
restore unix line endings using dos2unix
TimidRobot 570fbbf
restore unix line endings using dos2unix
TimidRobot b70138c
restore unix line endings using dos2unix
TimidRobot a607b46
branch updated
SisiVero 70f1bdb
redundant aria attrbutes removed and support for translation added wh…
SisiVero 3a1f67e
faq file patched
SisiVero 1d779e8
django translation syntax errors corrected.
SisiVero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{% extends 'legal_db/base.html' %} | ||
|
||
{% block body_content %} | ||
<main class="hero"> | ||
<main class="hero" aria-label="Error Page"> | ||
<div class="hero-body has-text-centered"> | ||
<h1 class="hero-title-big">404</h1> | ||
<h2 class="b-header">Page Not Found!</h2> | ||
<p class="margin-vertical-normal">The page you are looking for doesn't exist.</p> | ||
<a href="{% url 'home' %}" class="button">Return Home</a> | ||
<a href="{% url 'home' %}" class="button" role="button">Return Home</a> | ||
</div> | ||
</main> | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,24 @@ | ||
{% load widget_tweaks %} | ||
|
||
<section class="columns is-gapless is-vcentered margin-top-big margin-bottom-small"> | ||
<section class="columns is-gapless is-vcentered margin-top-big margin-bottom-small" aria-label="Search and Filters"> | ||
<div class="column is-8"> | ||
<div role="search" method="get" class="field has-addons" aria-label="Search form"> | ||
<div class="field has-addons"> | ||
<div class="control has-icons-left search-input"> | ||
<label for="{{ form.keywords.id_for_label }}" class="is-sr-only">Search: </label> | ||
{% render_field form.keywords|add_class:"input" placeholder="Search for..." %} | ||
<span class="icon is-left"><i class="icon search"></i></span> | ||
<span class="icon is-left" aria-hidden="true"><i class="icon search"></i></span> | ||
</div> | ||
<div class="control is-4"> | ||
<button type="submit" class="button small">Search</button> | ||
<button type="submit" class="button small" aria-label="Submit search">Search</button> | ||
</div> | ||
</div> | ||
{{ form.keywords.errors }} | ||
</div> | ||
<div class="column"> | ||
<strong id="tags-filter" class="tags-filter margin-left-normal"> | ||
<span id="tags-hide">Hide topic filters <i class="icon chevron-up"></i></span> | ||
<span id="tags-show" class="is-hidden">Show topic filters <i class="icon chevron-down"></i></span> | ||
<strong id="tags-filter" class="tags-filter margin-left-normal" aria-label="Topic filters"> | ||
<span id="tags-hide" aria-controls="tags-filter">Hide topic filters <i class="icon chevron-up"></i></span> | ||
<span id="tags-show" class="is-hidden" aria-controls="tags-filter">Show topic filters <i class="icon chevron-down"></i></span> | ||
</strong> | ||
</div> | ||
</section> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,4 +42,4 @@ def main(): | |
except Exception: | ||
print("ERROR (1) Unhandled exception:", file=sys.stderr) | ||
print(traceback.print_exc(), file=sys.stderr) | ||
sys.exit(1) | ||
sys.exit(1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please restore the newline at end of file |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the string in translation tags: