Added ARIA attributes to essential elements #232

SisiVero · 2024-10-16T14:23:46Z

Fixes

Fixes [Bug] Enhance Accessibility: Missing ARIA Roles #214 by @Silvia-Wachira

Description

The PR addresses the issue of adding ARIA attributes to essential components relative to legaldb.

Technical details

The footer and header files were untouched as changes from the vocabulary will be effected in it.

Checklist

My pull request has a descriptive title (not a vague title like Update index.md).
My pull request targets the default branch of the repository (main or master).
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

TimidRobot

Please resolve conflicts and remove whitespace changes (you've replaced unix LF line endings with Windows CRLF line endings)

SisiVero · 2024-10-22T18:32:39Z

Please resolve conflicts and remove whitespace changes (you've replaced unix LF line endings with Windows CRLF line endings)

I'll resolve them asap.
Thank you

TimidRobot

Please:

reduce the changes so that there isn't duplication of existing elements/text
- ARIA - Accessibility | MDN
  
  The first rule of ARIA use is "If you can use a native HTML element or attribute with the semantics and behavior you require already built in, instead of re-purposing an element and adding an ARIA role, state or property to make it accessible, then do so."
Resolve conflicts with main branch
- Resolving a merge conflict on GitHub - GitHub Docs
Add support for translation for added strings, where appropriate
- Implement i18n support #243
- Translation | Django documentation | Django

SisiVero · 2024-11-14T19:15:22Z

@TimidRobot noted.
Changes will be effected and committed.
Thank you.

SisiVero · 2024-11-14T20:47:48Z

@TimidRobot noted. Changes will be effected and committed. Thank you.

This might take a little while as I would love to go through the contents of the link you provided, as it would help me understand better what to do and not to do when adding ARIA attributes.

…ere needed/appropriate

SisiVero · 2024-11-17T12:19:14Z

Please:

reduce the changes so that there isn't duplication of existing elements/text

ARIA - Accessibility | MDN

The first rule of ARIA use is "If you can use a native HTML element or attribute with the semantics and behavior you require already built in, instead of re-purposing an element and adding an ARIA role, state or property to make it accessible, then do so."

Resolve conflicts with main branch

Resolving a merge conflict on GitHub - GitHub Docs

Add support for translation for added strings, where appropriate

Implement i18n support #243

Translation | Django documentation | Django

Hi @TimidRobot , Corrections have been effected as requested. Do review when you can. Thank you.

TimidRobot

Very close! Just a few small changes

TimidRobot · 2024-11-19T21:46:38Z

legal_db/templates/legal_db/case/form.html

@@ -167,7 +167,7 @@ <h4 class="b-header">{% trans "Links to relevant materials" %}</h4>
                    {{ link_form.url.errors }}
                  </div>
                  <div class="column is-1">
-                    <button type="button" class="button is-delete" onclick="deleteLinkForm('link-form-{{ forloop.counter0 }}')">
+                    <button type="button" class="button is-delete" onclick="deleteLinkForm('link-form-{{ forloop.counter0 }}')" aria-label="Delete this link form">


Please put the string in translation tags:

aria-label="{% trans 'Delete this link form' %}"

TimidRobot · 2024-11-19T21:47:17Z

legal_db/templates/legal_db/faq.html

@@ -19,7 +19,7 @@ <h1 class="hero-title title is-2">{% trans "Frequently Asked Questions" %}</h1>
        </div>
        <div>
          {% for faq in faqs %}
-          <article class="faq__content">
+          <article class="faq__content" aria-label="Frequently Asked Questions">


Please put the string in trans tags:

aria-label="{% trans 'Frequently Asked Questions' %}"

TimidRobot · 2024-11-19T21:48:37Z

manage.py

@@ -42,4 +42,4 @@ def main():
    except Exception:
        print("ERROR (1) Unhandled exception:", file=sys.stderr)
        print(traceback.print_exc(), file=sys.stderr)
-        sys.exit(1)
+        sys.exit(1)


Please restore the newline at end of file

addingg aria attributes

d46d9a9

SisiVero marked this pull request as ready for review October 16, 2024 15:49

SisiVero requested review from a team as code owners October 16, 2024 15:49

SisiVero requested review from TimidRobot, possumbilities and krysal and removed request for a team October 16, 2024 15:49

updated 404 page

c6fd06f

SisiVero changed the title ~~adding aria attributes~~ Added ARIA attributes to essential elements Oct 17, 2024

TimidRobot requested changes Oct 22, 2024

View reviewed changes

SisiVero added 2 commits October 22, 2024 12:52

Merge branch 'main' changes into aria-attributes

be867f1

conflict resolved.

e408c20

SisiVero requested a review from TimidRobot October 22, 2024 20:00

TimidRobot added 3 commits November 1, 2024 11:48

restore unix line endings using dos2unix

640d151

restore unix line endings using dos2unix

570fbbf

restore unix line endings using dos2unix

b70138c

TimidRobot self-assigned this Nov 4, 2024

TimidRobot requested changes Nov 14, 2024

View reviewed changes

branch updated

a607b46

redundant aria attrbutes removed and support for translation added wh…

70f1bdb

…ere needed/appropriate

SisiVero requested a review from TimidRobot November 17, 2024 11:47

SisiVero added 2 commits November 17, 2024 03:54

faq file patched

3a1f67e

django translation syntax errors corrected.

1d779e8

TimidRobot requested changes Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ARIA attributes to essential elements #232

Added ARIA attributes to essential elements #232

SisiVero commented Oct 16, 2024 •

edited

Loading

TimidRobot left a comment

SisiVero commented Oct 22, 2024

TimidRobot left a comment •

edited

Loading

SisiVero commented Nov 14, 2024

SisiVero commented Nov 14, 2024

SisiVero commented Nov 17, 2024

TimidRobot left a comment

TimidRobot Nov 19, 2024

TimidRobot Nov 19, 2024

TimidRobot Nov 19, 2024

Added ARIA attributes to essential elements #232

Are you sure you want to change the base?

Added ARIA attributes to essential elements #232

Conversation

SisiVero commented Oct 16, 2024 • edited Loading

Fixes

Description

Technical details

Checklist

Developer Certificate of Origin

TimidRobot left a comment

Choose a reason for hiding this comment

SisiVero commented Oct 22, 2024

TimidRobot left a comment • edited Loading

Choose a reason for hiding this comment

SisiVero commented Nov 14, 2024

SisiVero commented Nov 14, 2024

SisiVero commented Nov 17, 2024

TimidRobot left a comment

Choose a reason for hiding this comment

TimidRobot Nov 19, 2024

Choose a reason for hiding this comment

TimidRobot Nov 19, 2024

Choose a reason for hiding this comment

TimidRobot Nov 19, 2024

Choose a reason for hiding this comment

SisiVero commented Oct 16, 2024 •

edited

Loading

TimidRobot left a comment •

edited

Loading