Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE]update the squid image version #4555

Closed
wants to merge 1 commit into from
Closed

[QE]update the squid image version #4555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/testsuite/testsuite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func InitializeScenario(s *godog.ScenarioContext) {
if tag.Name == "@proxy" {

// start container with squid proxy
err := util.ExecuteCommand("podman run --name squid -d -p 3128:3128 quay.io/crcont/squid")
err := util.ExecuteCommand("podman run --name squid -d -p 3128:3128 quay.io/crcont/squid:5.5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://quay.io/repository/crcont/squid?tab=tags has a 5.5 tag which was just created, and a latest tag which is 4 years old. Is there any reason for not updating the latest tag to point to the same image as the 5.5 tag? Then the test suite would automatically pick up the new image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use latest tag. But the drawback is difficult to track back if image change.
@praveenkumar WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am mapping 5.5 to latest and keeping both the tag so we can also able to track back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use latest tag. But the drawback is difficult to track back if image change.

I think it is fairly common to have a moving latest tag, plus non-moving versioned tags (eg 5.5), this way we get the best of both worlds :)

if err != nil {
fmt.Println(err)
os.Exit(1)
Expand Down
Loading