[QE]update the squid image version #4555
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -215,7 +215,7 @@ func InitializeScenario(s *godog.ScenarioContext) { | |||
| if tag.Name == "@proxy" { | |||
|
|
|||
| // start container with squid proxy | |||
| err := util.ExecuteCommand("podman run --name squid -d -p 3128:3128 quay.io/crcont/squid") | |||
| err := util.ExecuteCommand("podman run --name squid -d -p 3128:3128 quay.io/crcont/squid:5.5") | |||
There was a problem hiding this comment.
https://quay.io/repository/crcont/squid?tab=tags has a 5.5 tag which was just created, and a latest tag which is 4 years old. Is there any reason for not updating the latest tag to point to the same image as the 5.5 tag? Then the test suite would automatically pick up the new image.
There was a problem hiding this comment.
I prefer to use latest tag. But the drawback is difficult to track back if image change.
@praveenkumar WDYT?
There was a problem hiding this comment.
I am mapping 5.5 to latest and keeping both the tag so we can also able to track back.
There was a problem hiding this comment.
I prefer to use latest tag. But the drawback is difficult to track back if image change.
I think it is fairly common to have a moving latest tag, plus non-moving versioned tags (eg 5.5), this way we get the best of both worlds :)
|
/close |
|
@praveenkumar: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Relates to: #4551
Type of change
test, version modification, documentation, etc.)
Proposed changes
Testing
Contribution Checklist