Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: microshift: Don't force network-mode to 'user' #3804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: microshift: Don't force network-mode to 'user' #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d71018
test: microshift: Don't force network-mode to 'user'
cfergeau Aug 25, 2023
9bae8e5
Revert "e2e test: Ignore network-mode config property for non linux p…
cfergeau Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/e2e/features/story_microshift.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Microshift test stories

Background:
Given setting config property "preset" to value "microshift" succeeds
And setting config property "network-mode" to value "user" succeeds
And executing single crc setup command succeeds
And starting CRC with default bundle succeeds
And ensuring oc command is available
Expand Down Expand Up @@ -34,4 +33,4 @@ Feature: Microshift test stories
And with up to "4" retries with wait period of "1m" http response from "http://httpd-example-testproj.apps.crc.testing" has status code "200"
Then executing "curl -s http://httpd-example-testproj.apps.crc.testing" succeeds
And stdout should contain "Hello CRC!"
Then with up to "4" retries with wait period of "1m" http response from "http://httpd-example-testproj.apps.crc.testing" has status code "200"
Then with up to "4" retries with wait period of "1m" http response from "http://httpd-example-testproj.apps.crc.testing" has status code "200"
4 changes: 0 additions & 4 deletions test/e2e/testsuite/testsuite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,10 +865,6 @@ func setOcEnv() error {
}

func SetConfigPropertyToValueSucceedsOrFails(property string, value string, expected string) error {
// Since network-mode is only supported on Linux, we skip this property test for non-linux platforms
if property == "network-mode" && runtime.GOOS != "linux" {
return nil
}
if value == "current bundle" {
if !userProvidedBundle {
value = filepath.Join(util.CRCHome, "cache", bundleName)
Expand Down