Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: microshift: Don't force network-mode to 'user' #3804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cfergeau
Copy link
Contributor

Filing this now so that we don't forget it when we have bundles with crc-org/snc#797. This will be put on hold until this happens.

We want our testing to be as close as possible to what end-users will
experience. Changing network-mode is a significant difference from the
default. With crc-org/snc#797 fixed, we no longer
need to force it to user.

We want our testing to be as close as possible to what end-users will
experience. Changing `network-mode` is a significant difference from the
default.
With crc-org/snc#797 fixed, we no longer need to
force it to `user`.
…latform"

This reverts commit 557ec94.

We no longer set network-mode as part of the tests, so this code is not
needed.
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Contributor Author

/hold

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 9bae8e5 link true /test e2e-microshift-crc
ci/prow/integration-crc 9bae8e5 link true /test integration-crc
ci/prow/e2e-crc 9bae8e5 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@praveenkumar
Copy link
Member

@jsliacan Can you try that and see if that works as expected.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants