Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregate function tests. Use CVL for expected output. #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add aggregate function tests. Use CVL for expected output. #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 49 additions & 3 deletions tests/cql/CqlAggregateFunctionsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
<expression>AllTrue({})</expression>
<output>true</output>
</test>
<test name="AllTrueIsTrueWhenNull">
<expression>AllTrue(null)</expression>
<output>true</output>
</test>
</group>
<group name="AnyTrue">
<test name="AnyTrueAllTrue">
Expand Down Expand Up @@ -68,13 +72,23 @@
<expression>AnyTrue({})</expression>
<output>false</output>
</test>
<test name="AnyTrueIsFalseWhenNull">
<expression>AnyTrue(null)</expression>
<output>false</output>
</test>
</group>
<group name="Avg">
<test name="AvgTest1">
<expression>Avg({ 1.0, 2.0, 3.0, 6.0 })</expression>
<output>3.0</output>
</test>
</group>
<group name="Product">
<test name="Product_Long">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think underscores are used anywhere else for test names in this repo, so consider remaining consistent

Suggested change
<test name="Product_Long">
<test name="ProductLong">

I personally don't feel that strongly though.

<expression>Product({5L, 4L, 5L})</expression>
<output>100L</output>
</test>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add other product tests (e.g. for other overloads, null input, etc) or should that come in another PR? (same comment for the other operators)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here if we're going to add this test group we should have a few more edge cases covered

</group>
<group name="Count">
<test name="CountTest1">
<expression>Count({ 15, 5, 99, null, 1 })</expression>
Expand All @@ -98,13 +112,17 @@
<expression>Max({ 5, 12, 1, 15, 0, 4, 90, 44 })</expression>
<output>90</output>
</test>
<test name="MaxTestLong">
<expression>Max({ 5L, 12L, 1L, 15L, 0L, 4L, 90L, 44L })</expression>
<output>90L</output>
</test>
<test name="MaxTestString">
<expression>Max({ 'hi', 'bye', 'zebra' })</expression>
<output>'zebra'</output>
</test>
<test name="MaxTestDateTime">
<expression>Max({ DateTime(2012, 10, 5), DateTime(2012, 9, 5), DateTime(2012, 10, 6) })</expression>
<output>DateTime(2012, 10, 6)</output>
<output>@2012-10-06T</output>
</test>
<test name="MaxTestTime">
<expression>Max({ @T15:59:59.999, @T05:59:59.999, @T20:59:59.999 })</expression>
Expand All @@ -122,13 +140,17 @@
<expression>Min({5, 12, 1, 15, 0, 4, 90, 44})</expression>
<output>0</output>
</test>
<test name="MinTestLong">
<expression>Min({5L, 12L, 1L, 15L, 0L, 4L, 90L, 44L})</expression>
<output>0L</output>
</test>
<test name="MinTestString">
<expression>Min({'hi', 'bye', 'zebra'})</expression>
<output>'bye'</output>
</test>
<test name="MinTestDateTime">
<expression>Min({ DateTime(2012, 10, 5), DateTime(2012, 9, 5), DateTime(2012, 10, 6) })</expression>
<output>DateTime(2012, 9, 5)</output>
<output>@2012-09-05T</output>
</test>
<test name="MinTestTime">
<expression>Min({ @T15:59:59.999, @T05:59:59.999, @T20:59:59.999 })</expression>
Expand All @@ -142,7 +164,11 @@
</test>
<test name="ModeTestDateTime">
<expression>Mode({ DateTime(2012, 10, 5), DateTime(2012, 9, 5), DateTime(2012, 10, 6), DateTime(2012, 9, 5) })</expression>
<output>DateTime(2012, 9, 5)</output>
<output>@2012-09-05T</output>
</test>
<test name="ModeTestDateTime2">
<expression>Mode({ DateTime(2012, 10, 5), DateTime(2012, 10, 5), DateTime(2012, 10, 6), DateTime(2012, 9, 5) })</expression>
<output>@2012-10-05T</output>
</test>
<test name="ModeTestTime">
<expression>Mode({ @T15:59:59.999, @T05:59:59.999, @T20:59:59.999, @T05:59:59.999 })</expression>
Expand All @@ -155,25 +181,45 @@
<output>1.41421356</output>
<!-- 23730951454746218587388284504413604736328125 -->
</test>
<test name="PopulationStdDevIsNull">
<expression>PopulationStdDev({ null as Quantity, null as Quantity, null as Quantity })</expression>
<output>null</output>
</test>
</group>
<group name="PopulationVariance">
<test name="PopVarianceTest1">
<expression>PopulationVariance({ 1.0, 2.0, 3.0, 4.0, 5.0 })</expression>
<output>2.0</output>
</test>
<test name="PopVarianceIsNull">
<expression>PopulationVariance({ null as Quantity, null as Quantity, null as Quantity })</expression>
<output>null</output>
</test>
</group>
<group name="StdDev">
<test name="StdDevTest1">
<expression>StdDev({ 1.0, 2.0, 3.0, 4.0, 5.0 })</expression>
<output>1.58113883</output>
<!-- 00841897613935316257993690669536590576171875 -->
</test>
<test name="StdDevIsNull">
<expression>StdDev({ null as Quantity, null as Quantity, null as Quantity })</expression>
<output>null</output>
</test>
</group>
<group name="Sum">
<test name="SumTest1">
<expression>Sum({ 6.0, 2.0, 3.0, 4.0, 5.0 })</expression>
<output>20.0</output>
</test>
<test name="SumTestLong">
<expression>Sum({ 6L, 2L, 3L, 4L, 5L })</expression>
<output>20L</output>
</test>
<test name="SumTestQuantity">
<expression>Sum({1 'ml',2 'ml',3 'ml',4 'ml',5 'ml'})</expression>
<output>15 'ml'</output>
</test>
<test name="SumTestNull">
<expression>Sum({ null, 1, null })</expression>
<output>1</output>
Expand Down