Add aggregate function tests. Use CVL for expected output. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynrhodes
approved these changes
Aug 2, 2024
suyashkumar
approved these changes
Aug 2, 2024
| </group> | ||
| <group name="Avg"> | ||
| <test name="AvgTest1"> | ||
| <expression>Avg({ 1.0, 2.0, 3.0, 6.0 })</expression> | ||
| <output>3.0</output> | ||
| </test> | ||
| </group> | ||
| <group name="Product"> | ||
| <test name="Product_Long"> |
There was a problem hiding this comment.
nit: I don't think underscores are used anywhere else for test names in this repo, so consider remaining consistent
Suggested change
| <test name="Product_Long"> | |
| <test name="ProductLong"> |
I personally don't feel that strongly though.
| <test name="Product_Long"> | ||
| <expression>Product({5L, 4L, 5L})</expression> | ||
| <output>100L</output> | ||
| </test> |
There was a problem hiding this comment.
should we add other product tests (e.g. for other overloads, null input, etc) or should that come in another PR? (same comment for the other operators)
There was a problem hiding this comment.
+1 here if we're going to add this test group we should have a few more edge cases covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new conformance tests for aggregate functions. I picked all the ones from https://github.com/cqframework/clinical_quality_language/blob/7e91478/Src/java/engine/src/test/resources/org/opencds/cqf/cql/engine/execution/CqlAggregateFunctionsTest.cql which didn't exist yet here.
Using CVL (literals only) for the expected output values, building on top of #29. Focusing only on the
tests/cql/CqlAggregateFunctionsTest.xmltests.