Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm tools/hubl #23562

Merged
merged 4 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
/store/ @cosmos/sdk-core-dev
/store/v2/ @cosmos/sdk-core-dev
/types/mempool/ @cosmos/sdk-core-dev
/tools/hubl @julienrbrt @JulianToledano @cosmos/sdk-core-dev
/tools/cosmovisor @julienrbrt @cosmos/sdk-core-dev
/tools/confix @julienrbrt @cosmos/sdk-core-dev
/tests/integration/aminojson @cosmos/sdk-core-dev
Expand Down
9 changes: 0 additions & 9 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,6 @@ updates:
labels:
- "A:automerge"
- dependencies
- package-ecosystem: gomod
directory: "/tools/hubl"
schedule:
interval: weekly
day: thursday
time: "02:15"
labels:
- "A:automerge"
- dependencies
- package-ecosystem: gomod
directory: "/collections"
schedule:
Expand Down
2 changes: 0 additions & 2 deletions .github/pr_labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
- tools/confix/**/*
"C:Cosmovisor":
- tools/cosmovisor/**/*
"C:Hubl":
- tools/hubl/**/*
"C:Keys":
- client/keys/**/*
"C:Simulations":
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,3 @@ jobs:
run: GOARCH=${{ matrix.go-arch }} make cosmovisor
- name: Build Confix
run: GOARCH=${{ matrix.go-arch }} make confix
- name: Build Hubl
run: GOARCH=${{ matrix.go-arch }} make hubl
31 changes: 0 additions & 31 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -630,37 +630,6 @@ jobs:
with:
projectBaseDir: tools/confix/

test-hubl:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.23"
check-latest: true
cache: true
cache-dependency-path: tools/hubl/go.sum
- uses: technote-space/[email protected]
id: git_diff
with:
PATTERNS: |
tools/hubl/**/*.go
tools/hubl/go.mod
tools/hubl/go.sum
- name: tests
if: env.GIT_DIFF
run: |
cd tools/hubl
go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock' ./...
- name: sonarcloud
if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
projectBaseDir: tools/hubl/

test-store:
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i

### Bug Fixes

### Removed

* (tools/hub) []() Remove `tools/hubl`. A similar tool will be maintained in [ignite](https://www.github.com/ignite/cli).

### API Breaking Changes

* (x/params) [#22995](https://github.com/cosmos/cosmos-sdk/pull/22995) Remove `x/params`. Migrate to the new params system introduced in `v0.47` as demonstrated [here](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#xparams).
Expand Down
5 changes: 2 additions & 3 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Welcome to the Cosmos SDK's team roadmap.
* [x] Multi-chain command **(Done)**
* Release a cmd line tool that can be pointed a grpc endpoint which then can produce cmd lines to interact with the chain
* [x] Auto-cli tx support
* Tx support for auto-cli/hubl
* Tx support for auto-cli
* This would fully remove the need for application developers to write cli commands for their modules
* [ ] [Consensus Key Rotation](https://github.com/cosmos/cosmos-sdk/issues/5231)

Expand Down Expand Up @@ -121,9 +121,8 @@ Issue: https://github.com/cosmos/iavl/issues/548

### Client UX

* [ ] Hubl/AutoCLI
* [ ] AutoCLI
* Objective:
* Allow users to sign and submit transactions using hubl
* Add module support for autocli
* Deprecate/remove legacy cli (optional)
* Progress:
Expand Down
2 changes: 0 additions & 2 deletions UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -1236,8 +1236,6 @@ For example, assuming you put all your proto files in subfolders inside your roo

If you are using a custom folder structure for your proto files, please reorganize them so that their OS path matches their proto package name.

This is to allow the proto FileDescriptSets to be correctly registered, and this standardized OS import paths allows [Hubl](https://github.com/cosmos/cosmos-sdk/tree/main/tools/hubl) to reflectively talk to any chain.

#### `{accepts,implements}_interface` proto annotations

The SDK is normalizing the strings inside the Protobuf `accepts_interface` and `implements_interface` annotations. We require them to be fully-scoped names. They will soon be used by code generators like Pulsar and Telescope to match which messages can or cannot be packed inside `Any`s.
Expand Down
6 changes: 1 addition & 5 deletions client/v2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ The keyring is then converted to the `client/v2/autocli/keyring` interface.
If no keyring is provided, the `autocli` generated command will not be able to sign transactions, but will still be able to query the chain.

:::tip
The Cosmos SDK keyring and Hubl keyring both implement the `client/v2/autocli/keyring` interface, thanks to the following wrapper:
The Cosmos SDK keyring implements the `client/v2/autocli/keyring` interface, thanks to the following wrapper:

```go
keyring.NewAutoCLIKeyring(kb)
Expand Down Expand Up @@ -283,10 +283,6 @@ According to the [Cobra documentation](https://pkg.go.dev/github.com/spf13/cobra

`autocli` lets you generate CLI to your Cosmos SDK-based applications without any cobra boilerplate. It allows you to easily generate CLI commands and flags from your protobuf messages, and provides many options for customising the behavior of your CLI application.

To further enhance your CLI experience with Cosmos SDK-based blockchains, you can use `hubl`. `hubl` is a tool that allows you to query any Cosmos SDK-based blockchain using the new AutoCLI feature of the Cosmos SDK. With `hubl`, you can easily configure a new chain and query modules with just a few simple commands.

For more information on `hubl`, including how to configure a new chain and query a module, see the [Hubl documentation](https://docs.cosmos.network/main/build/tooling/hubl).

# Off-Chain

Off-chain is a `client/v2` package providing functionalities for allowing to sign and verify files with two commands:
Expand Down
1 change: 0 additions & 1 deletion docs/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ docs/architecture
docs/rfc
docs/tooling/01-cosmovisor.md
docs/tooling/02-confix.md
docs/tooling/03-hubl.md
docs/core/17-autocli.md
docs/packages/01-depinject.md
docs/packages/02-collections.md
Expand Down
1 change: 0 additions & 1 deletion docs/build/tooling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ This includes tools for development, operating a node, and ease of use of a Cosm

* [Cosmovisor](./01-cosmovisor.md)
* [Confix](./02-confix.md)
* [Hubl](./03-hubl.md)
* [Rosetta](https://docs.cosmos.network/main/run-node/rosetta)

## Other Tools
Expand Down
1 change: 0 additions & 1 deletion docs/post.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
find build/modules ! -name '_category_.json' -type f -exec rm -rf {} +
rm -rf build/tooling/01-cosmovisor.md
rm -rf build/tooling/02-confix.md
rm -rf build/tooling/03-hubl.md
rm -rf build/packages/01-depinject.md
rm -rf build/packages/02-collections.md
rm -rf build/packages/03-orm.md
Expand Down
1 change: 0 additions & 1 deletion docs/pre.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ cat ../x/README.md | sed 's/\.\.\/\/build\/building-modules\/README\.md/\/buildi
## Add tooling documentation
cp ../tools/cosmovisor/README.md ./build/tooling/01-cosmovisor.md
cp ../tools/confix/README.md ./build/tooling/02-confix.md
cp ../tools/hubl/README.md ./build/tooling/03-hubl.md

## Add package documentation
cp ../client/v2/README.md ./learn/advanced/17-autocli.md
Expand Down
1 change: 0 additions & 1 deletion go.work.example
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ use (
./runtime/v2
./tools/cosmovisor
./tools/confix
./tools/hubl
./tools/benchmark
./x/accounts
./x/accounts/defaults/base
Expand Down
4 changes: 0 additions & 4 deletions scripts/build/build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,6 @@ cosmovisor:
confix:
$(MAKE) -C tools/confix confix

#? hubl: Build hubl
hubl:
$(MAKE) -C tools/hubl hubl

.PHONY: build build-linux-amd64 build-linux-arm64 cosmovisor confix

#? mocks: Generate mock file
Expand Down
1 change: 0 additions & 1 deletion tools/hubl/.gitignore

This file was deleted.

32 changes: 0 additions & 32 deletions tools/hubl/CHANGELOG.md

This file was deleted.

12 changes: 0 additions & 12 deletions tools/hubl/Makefile

This file was deleted.

73 changes: 0 additions & 73 deletions tools/hubl/README.md

This file was deleted.

16 changes: 0 additions & 16 deletions tools/hubl/cmd/hubl/main.go

This file was deleted.

Loading
Loading