chore: rm tools/hubl
#23562
chore: rm tools/hubl
#23562
Conversation
aljo242
requested review from
julienrbrt,
tac0turtle,
a team and
JulianToledano
as code owners
📝 WalkthroughWalkthroughThis pull request involves the comprehensive removal of the Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
54-54: Fix empty link in changelogThere is an empty link
[]()which should either be removed or populated with proper link text and URL.- []() + <!-- Remove this empty link -->🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
54-54: No empty links
null(MD042, no-empty-links)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
tools/hubl/go.sumis excluded by!**/*.sum
📒 Files selected for processing (32)
.github/CODEOWNERS(0 hunks).github/dependabot.yml(0 hunks).github/pr_labeler.yml(0 hunks).github/workflows/build.yml(0 hunks).github/workflows/test.yml(0 hunks)CHANGELOG.md(1 hunks)ROADMAP.md(2 hunks)UPGRADING.md(0 hunks)client/v2/README.md(1 hunks)docs/.gitignore(0 hunks)docs/build/tooling/README.md(0 hunks)docs/post.sh(0 hunks)docs/pre.sh(0 hunks)go.work.example(0 hunks)scripts/build/build.mk(0 hunks)tools/hubl/.gitignore(0 hunks)tools/hubl/CHANGELOG.md(0 hunks)tools/hubl/Makefile(0 hunks)tools/hubl/README.md(0 hunks)tools/hubl/cmd/hubl/main.go(0 hunks)tools/hubl/go.mod(0 hunks)tools/hubl/internal/compat.go(0 hunks)tools/hubl/internal/config/config.go(0 hunks)tools/hubl/internal/flags/flags.go(0 hunks)tools/hubl/internal/keyring.go(0 hunks)tools/hubl/internal/load.go(0 hunks)tools/hubl/internal/registry.go(0 hunks)tools/hubl/internal/remote.go(0 hunks)tools/hubl/internal/root.go(0 hunks)tools/hubl/internal/util.go(0 hunks)tools/hubl/internal/version.go(0 hunks)tools/hubl/sonar-project.properties(0 hunks)
💤 Files with no reviewable changes (29)
- go.work.example
- tools/hubl/.gitignore
- docs/pre.sh
- docs/post.sh
- scripts/build/build.mk
- docs/.gitignore
- tools/hubl/go.mod
- tools/hubl/README.md
- tools/hubl/cmd/hubl/main.go
- tools/hubl/Makefile
- docs/build/tooling/README.md
- tools/hubl/internal/root.go
- .github/pr_labeler.yml
- tools/hubl/CHANGELOG.md
- tools/hubl/sonar-project.properties
- tools/hubl/internal/keyring.go
- .github/dependabot.yml
- .github/CODEOWNERS
- tools/hubl/internal/config/config.go
- tools/hubl/internal/flags/flags.go
- tools/hubl/internal/version.go
- .github/workflows/build.yml
- tools/hubl/internal/util.go
- tools/hubl/internal/compat.go
- tools/hubl/internal/registry.go
- tools/hubl/internal/remote.go
- UPGRADING.md
- tools/hubl/internal/load.go
- .github/workflows/test.yml
✅ Files skipped from review due to trivial changes (1)
- client/v2/README.md
🧰 Additional context used
📓 Path-based instructions (2)
ROADMAP.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
54-54: No empty links
null
(MD042, no-empty-links)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: repo-analysis
- GitHub Check: build (arm64)
- GitHub Check: Analyze
- GitHub Check: build (amd64)
- GitHub Check: dependency-review
- GitHub Check: golangci-lint
- GitHub Check: markdown-link-check
- GitHub Check: Summary
🔇 Additional comments (3)
ROADMAP.md (2)
34-34: LGTM! Task description updated correctly.The simplified task description aligns with the PR objective of removing hubl references.
124-124: LGTM! AutoCLI section updated correctly.The section has been appropriately updated to focus solely on AutoCLI, which aligns with the PR objective of removing hubl references.
CHANGELOG.md (1)
Line range hint
1-2000: LGTM! Well-structured changelog following best practicesThe changelog is well organized with:
- Clear version sections with dates
- Categorized changes (Features, Improvements, Bug Fixes etc.)
- Detailed descriptions with PR/Issue references
- Breaking changes clearly highlighted
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
54-54: No empty links
null(MD042, no-empty-links)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
Line range hint
1-1: Add title to the CHANGELOG fileThe CHANGELOG file should start with a # CHANGELOG title for better documentation structure.
+ # CHANGELOG
52-54: Add version release date in consistent formatThe Unreleased section should follow the same date format as other releases (YYYY-MM-DD).
- ## [Unreleased] + ## [Unreleased] - TBD
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Analyze
- GitHub Check: build (arm64)
- GitHub Check: build (amd64)
- GitHub Check: dependency-review
- GitHub Check: golangci-lint
- GitHub Check: markdown-link-check
- GitHub Check: Summary
🔇 Additional comments (2)
CHANGELOG.md (2)
Line range hint
1-15: LGTM: Well-structured changelog guidelinesThe guiding principles section clearly explains the purpose and format of the changelog, which is essential for maintainers.
Line range hint
1-1000: Verify all referenced PR linksThe changelog contains many PR references. We should verify that all these links are valid and accessible.
✅ Verification successful
All PR references in the changelog appear to be valid and properly formatted
The verification process checked a sample of PR links (#18991, #19043, #18956, #18707, #18772) and confirmed they all exist in the repository. The changelog follows a consistent format for PR references, and all tested links were accessible. While we tested a sample due to API rate limits, the consistent format and successful sample verification suggest all PR references are properly maintained.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Extract PR numbers and verify they exist in the repository prNumbers=$(grep -o '#[0-9]\{4,5\}' CHANGELOG.md | tr -d '#') for pr in $prNumbers; do gh pr view "$pr" --repo cosmos/cosmos-sdk >/dev/null 2>&1 if [ $? -ne 0 ]; then echo "PR #$pr not found" fi doneLength of output: 111
Script:
#!/bin/bash # Clone the repository and verify PR links git clone https://github.com/cosmos/cosmos-sdk.git cd cosmos-sdk git checkout v0.50.3 # Extract PR numbers and verify they exist prNumbers=$(grep -o '#[0-9]\{4,5\}' CHANGELOG.md | tr -d '#') echo "Found PR numbers:" echo "$prNumbers" # Test a few PRs to verify they exist # We'll check the first 5 PRs to avoid hitting API rate limits count=0 for pr in $prNumbers; do if [ $count -ge 5 ]; then break fi echo "Checking PR #$pr..." gh pr view "$pr" --repo cosmos/cosmos-sdk --json number,state >/dev/null 2>&1 if [ $? -ne 0 ]; then echo "PR #$pr not found or inaccessible" else echo "PR #$pr exists" fi count=$((count + 1)) doneLength of output: 7316
Description
Functionality similar to
hublwill be maintained in ignite, so this is one less thing to maintainAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Release Notes: Hubl Tool Deprecation
Deprecation
Impact
Next Steps