-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix unit tests for API #108[wip] #131
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
@naftalimurgor , good start :) To fix Prettier failed check just run I also noticed the title "test: fix tests unit tests for profile.controller.ts" - are you planning to do PR for each separately? |
Thanks for the pointing out the Regarding doing the tests seprately, we can do them all at once. This was just a way of making the draft PR active and to set the ball rolling on this issue |
@naftalimurgor , oh yes, it can be all in one. I guess when the first few are done, all the rest should go easy 🙂 |
profile.controller.ts
#108[wip]
Hey @vygandas |
Alright, no worries. Good luck with that! 😊 |
Thank you 😀 |
@naftalimurgor it's just prettier left 🤣 almost there... |
@vygandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
Awesome! |
[WIP] Fix API tests after adding ORM
The tests cover pretty much what's required, the tests break due to a broken
ts-auto-mock
, what's being done:ts-auto-mock
and use a package likejest-mock
to offer better mockingjest-mock
Currently usingjest.fn()
andjest.mock(...)
to mock most modules and methodsWhy is it needed?
This PR mainly aims at resolving #108 for Fixing failing API unit tests to resolve failing Github actions.
How to test it?
This PR is worked on as described in #108