Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with unit tests after adding TypeORM #108

Closed
vygandas opened this issue Nov 27, 2023 · 12 comments · Fixed by #131
Closed

Issue with unit tests after adding TypeORM #108

vygandas opened this issue Nov 27, 2023 · 12 comments · Fixed by #131
Assignees
@naftalimurgor
Labels
back-end Only back-end github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers help wanted Extra attention is needed
Milestone
[0] Basic necessi...

Comments

@vygandas
Copy link
Contributor

vygandas commented Nov 27, 2023 •
edited
Loading

Currently, we practically disabled unit tests in the API app because it was bottlenecking all other tickets. Decided not to delay TypeORM integration anymore and closed the PR. The problem is, that we have a bunch of new unit tests for API, which were moved from another project, but we never fixed tests that already were not working. It is needed to fix tests and make it all work ok. Some tests might be irrelevant, so making some adjustments is okay.

Acceptance criteria:

  • All tests are passing in CI and locally (in CI, it's running on affected areas, locally it's all)
  • Commands nx run api:test and nx run platform:test passing successfully with all tests
  • All the other checks are passing for the PR (tests, prettier, linting, code quality, etc)
@vygandas vygandas added good first issue Good for newcomers help wanted Extra attention is needed github_actions Pull requests that update GitHub Actions code back-end Only back-end labels Nov 27, 2023
@vygandas vygandas added this to the [0] Basic necessities milestone Nov 27, 2023
@vygandas vygandas changed the title Issue with unit tests [API] Issue with unit tests in backend app Nov 27, 2023
@jroper-scottlogic
Copy link

I'm looking to contribute to an open source project, could I be assigned this?

@vygandas
Copy link
Contributor Author

vygandas commented Nov 29, 2023 •
edited
Loading

@jroper-scottlogic hello. Yes, you can. However, it might be a good idea until I finish another PR #117 which is draft at the moment and very large.

@vygandas
Copy link
Contributor Author

@jroper-scottlogic , allright, massive change is about to be done. Let me know if you are going forward with this ticket. 😊

@jroper-scottlogic
Copy link

yeah, happy to start now!

@vygandas
Copy link
Contributor Author

@jroper-scottlogic awesome! 👍🏻 Check this out first https://github.com/cortip/isomera/blob/main/CONTRIBUTORS.md

@vygandas
Copy link
Contributor Author

vygandas commented Dec 3, 2023

@jroper-scottlogic any luck? :)

@vygandas vygandas changed the title [API] Issue with unit tests in backend app Issue with unit tests after adding TypeORM Dec 4, 2023
@vygandas
Copy link
Contributor Author

vygandas commented Dec 4, 2023

I am unasigning @jroper-scottlogic since it was 4 days without any activity.

@naftalimurgor
Copy link
Contributor

Hello,
I'd like to work on this as describe and would submit a WIP PR just to set the ball rolling on the issue. Please see the enclosed response on Upwork,
Warm regards,

@vygandas vygandas assigned vygandas and naftalimurgor and unassigned vygandas Dec 4, 2023
@vygandas
Copy link
Contributor Author

vygandas commented Dec 4, 2023

@naftalimurgor , go for it! 😉

@naftalimurgor
Copy link
Contributor

@vygandas
Let's get this done !

@demakoff
Copy link

demakoff commented Dec 4, 2023

Hey.
IFAIU the current one already taken by @naftalimurgor and the current Upwork task is not relevant.
@vygandas you can let me know if you will need any further assistance with this project.

@vygandas
Copy link
Contributor Author

vygandas commented Dec 4, 2023

@demakoff ah, sorry, forgot to make job private there. I will need more stuff done. First need to get this ready to unblock everything else. I'll take a note to ping you too, when new task appears

naftalimurgor added a commit to naftalimurgor/isomera that referenced this issue Dec 5, 2023
@naftalimurgor
test: fix tests unit tests for profile.controller.ts cortip#108
602f786
@naftalimurgor naftalimurgor mentioned this issue Dec 5, 2023
Merged
@vygandas vygandas linked a pull request Dec 5, 2023 that will close this issue
test: fix unit tests for API #108[wip] #131
Merged
naftalimurgor added a commit to naftalimurgor/isomera that referenced this issue Dec 6, 2023
@naftalimurgor
test: fix user.service tests cortip#108
26355dd
naftalimurgor added a commit to naftalimurgor/isomera that referenced this issue Dec 7, 2023
@naftalimurgor
test: fix local-auth.guard unit tests cortip#108
13ba95d
naftalimurgor added a commit to naftalimurgor/isomera that referenced this issue Dec 7, 2023
@naftalimurgor
test: fix local-auth.guard unit tests cortip#108
6134aa3
naftalimurgor added a commit to naftalimurgor/isomera that referenced this issue Dec 7, 2023
@naftalimurgor
test: fix token.interceptor test timing out cortip#108
5de6be9
vygandas pushed a commit that referenced this issue Dec 9, 2023
@naftalimurgor
test: fix unit tests for API #108[wip] (#131)
2c169bb 
* test: fix tests unit tests for `profile.controller.ts`  #108

* refactor: fix failing prettier lint in `profile.controller.spec.ts`

* test: fix `user.service` tests #108

* tests: fix test `user.service` tests

* test: fix `mailer.service` tests

* test: fix `confirm-code.service` tests

* test: fix `is-user-already-exist.validator` test

* test: fix  `auth.controller` tests

* tests: fix `auth.service` tests

* test: fix `local-auth.guard.`  tess

* chore: add `@golevel/ts-jest` dependency

* test: fix `token.interceptor` tests

* test: fix `local-auth.guard` unit tests #108

* test: fix `local-auth.guard` unit tests #108

* test: fix `token.interceptor` test timing out #108

* chore: fix lint problem, revert back to use `createMock`

* fix: fix lint errors `profile.controller.spec.ts`

* chore: clean up remove comments `local-auth.guard.spect.ts`

* test: fix 'auth.controller` login password testcase check

* refactor: minor refactor, set `user.password` to `undefined` in `auth.service`

* test: fix login/register testcases for `auth.controller.ts`

* test: fix assertion for password in user object

* refactor: revert back to `delete user.password` instead of setting value to undefined

* fix: prettier linting on `auth.controller`

* fix: prettier linting on `auth.controller` tests

* fix: prettier linting on `auth.service.spec.ts`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naftalimurgor naftalimurgor

Labels
back-end Only back-end github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers help wanted Extra attention is needed
Projects
Isomera Features
Status: ✅ Done
Milestone
[0] Basic necessities
Development

Successfully merging a pull request may close this issue.

test: fix unit tests for API #108[wip] naftalimurgor/isomera
4 participants
@vygandas @demakoff @naftalimurgor @jroper-scottlogic