Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignitor Implementation #185

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Ignitor Implementation #185

merged 1 commit into from
Jan 18, 2025

Conversation

bwz5
Copy link
Contributor

@bwz5 bwz5 commented Jan 11, 2025

No description provided.

@bwz5 Graphite App
Copy link
Contributor Author

bwz5 commented Jan 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bwz5 bwz5 mentioned this pull request Jan 11, 2025
Closed
@bwz5 bwz5 marked this pull request as ready for review January 11, 2025 20:52
ZachGarcia42
ZachGarcia42 requested changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to update the CI test expected output. Looks good otherwise!

fill/actuators/ignitor.cc Show resolved Hide resolved
fill/actuators/ignitor.cc Show resolved Hide resolved
@bwz5 bwz5 force-pushed the 01-10-adding_osx_toolchain branch from 2011930 to 34081c8 Compare January 18, 2025 02:13
@bwz5 bwz5 force-pushed the 01-11-ignitor_implementation branch from e302430 to 73914cc Compare January 18, 2025 02:13
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 18, 2025

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (01/18/25)

1 reviewer was added to this PR based on Zach Garcia's automation.

@bwz5 bwz5 force-pushed the 01-11-ignitor_implementation branch 3 times, most recently from c8aa9bd to 1fe7c3e Compare January 18, 2025 17:18
@bwz5 bwz5 changed the base branch from 01-10-adding_osx_toolchain to main January 18, 2025 17:18
@bwz5 bwz5 force-pushed the 01-11-ignitor_implementation branch 2 times, most recently from 5d9e49b to 8a82509 Compare January 18, 2025 17:38
ZachGarcia42
ZachGarcia42 reviewed Jan 18, 2025
View reviewed changes
.github/workflows/fill_station_action.yml
@@ -44,6 +44,7 @@ jobs:
bazel build //fill/lib/MockWiringPi:mock_wiringpi
./fill/setup_mock_wiringpi.sh
bazel build //fill:all
# ./fill/test/ignitor_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment tests

@bwz5 bwz5 force-pushed the 01-11-ignitor_implementation branch from 8a82509 to 1a17f0b Compare January 18, 2025 17:42
@bwz5 bwz5 force-pushed the 01-11-ignitor_implementation branch from 1a17f0b to e6958ea Compare January 18, 2025 17:45
@bwz5 Graphite App
Copy link
Contributor Author

bwz5 commented Jan 18, 2025 •
edited
Loading

Merge activity

  • Jan 18, 12:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 18, 12:52 PM EST: A user merged this pull request with Graphite.

@bwz5 bwz5 merged commit b8173fc into main Jan 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachGarcia42 ZachGarcia42 ZachGarcia42 approved these changes

@cameron-goddard cameron-goddard Awaiting requested review from cameron-goddard cameron-goddard is a code owner

@nragland nragland Awaiting requested review from nragland nragland is a code owner

@maxslarsson maxslarsson Awaiting requested review from maxslarsson maxslarsson is a code owner

@AlyNat75 AlyNat75 Awaiting requested review from AlyNat75 AlyNat75 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwz5 @ZachGarcia42 @cameron-goddard