Adding OSX toolchain #184
Open
Adding OSX toolchain #184
+136
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bwz5
requested review from
ZachGarcia42,
cameron-goddard,
nragland,
maxslarsson and
AlyNat75
as code owners
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (01/11/25)1 reviewer was added to this PR based on Zach Garcia's automation. |
ZachGarcia42
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Looks great Ben!! Thanks for getting this done!
Can you confirm that building all targets works on both platforms now (you can build from the mini PC to test x86)?
Please update the README with instructions for installing gcc on MacOS
If you want, pigweed's implementation of bazel tool chains is probably a good reference: https://github.com/google/pigweed/blob/main/pw_toolchain%2Farm_clang%2FBUILD.bazel
bwz5
force-pushed
the
01-10-adding_osx_toolchain
branch
from
2011930 to
34081c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.