Cleanup empty/unused files + lints

sdk/src/assertions/exif.rs

@@ -90,7 +90,7 @@ impl Exif {
                 v.push(value);
                 self
             }
-            None => self.insert(&key, &Vec::from([value]))?,
+            None => self.insert(&key, Vec::from([value]))?,
         })
     }
 

sdk/src/assertions/schema_org.rs

@@ -100,7 +100,7 @@ impl SchemaDotOrg {
                 v.push(value);
                 self
             }
-            None => self.insert(key, &Vec::from([value]))?,
+            None => self.insert(key, Vec::from([value]))?,
         })
     }
 

sdk/src/asset_handlers/bmff_io.rs

@@ -510,11 +510,7 @@ where
                     let desired_flags = u32::from_be_bytes(temp_bytes);
 
                     if let Some(box_flags) = box_info.flags {
-                        let exact = if let Some(is_exact) = bmff_exclusion.exact {
-                            is_exact
-                        } else {
-                            true
-                        };
+                        let exact = bmff_exclusion.exact.unwrap_or(true);
 
                         if exact {
                             if desired_flags != box_flags {

sdk/src/builder.rs

@@ -260,7 +260,7 @@ impl Builder {
         stream.read_to_end(&mut resource)?;
         // add the resource and set the resource reference
         self.resources
-            .add(&self.definition.instance_id.clone(), resource)?;
+            .add(self.definition.instance_id.clone(), resource)?;
         self.definition.thumbnail = Some(ResourceRef::new(
             format,
             self.definition.instance_id.clone(),
@@ -686,7 +686,7 @@ impl Builder {
             {
                 stream.rewind()?;
                 self.resources
-                    .add(&self.definition.instance_id.clone(), image)?;
+                    .add(self.definition.instance_id.clone(), image)?;
                 self.definition.thumbnail = Some(ResourceRef::new(
                     format,
                     self.definition.instance_id.clone(),
@@ -1114,7 +1114,7 @@ mod tests {
 
         let mut builder = Builder::from_json(&manifest_json()).unwrap();
         builder
-            .add_ingredient(&parent_json(), format, &mut source)
+            .add_ingredient(parent_json(), format, &mut source)
             .unwrap();
 
         builder

sdk/src/jumbf/boxes.rs

@@ -1728,11 +1728,7 @@ impl JUMBFEmbeddedFileDescriptionBox {
             .position(|&c| c == b'\0')
             .unwrap_or(bytes.len());
 
-        if let Ok(r_str) = String::from_utf8(bytes[0..nul_range_end].to_vec()) {
-            r_str
-        } else {
-            String::new()
-        }
+        String::from_utf8(bytes[0..nul_range_end].to_vec()).unwrap_or_default()
     }
 
     pub fn media_type(&self) -> String {

sdk/src/lib.rs

@@ -11,7 +11,6 @@
 // specific language governing permissions and limitations under
 // each license.
 
-#![deny(warnings)]
 #![deny(clippy::expect_used)]
 #![deny(clippy::panic)]
 #![deny(clippy::unwrap_used)]

sdk/src/resource_store.rs

@@ -442,10 +442,10 @@ mod tests {
 
         let mut builder = Builder::from_json(json).expect("from json");
         builder
-            .add_resource("abc123", &mut Cursor::new(value))
+            .add_resource("abc123", Cursor::new(value))
             .expect("add_resource");
         builder
-            .add_resource("cba321", &mut Cursor::new(value))
+            .add_resource("cba321", Cursor::new(value))
             .expect("add_resource");
 
         let image = include_bytes!("../tests/fixtures/earth_apollo17.jpg");