Cleanup empty/unused files + lints #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok-nick
changed the title
gpeacock
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Removes
sdk/src/manifest2.rs(accidental merge) andsdk/src/embedded_xmp.rs(no longer used w/ xmp_toolkit). Also cleans up some lints reported by clippy.ALSO removes
#[deny(warnings)]in lib.rs as it causes rust-analyzer to fail to analyze tests when lint errors occur and fails to compile when running tests locally. The CI still denies warnings, so no changes there.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.