Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace /usr/local/sbin/unminimize with unminimize in apt #1567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

Replace /usr/local/sbin/unminimize with unminimize in apt #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
985940f
images: ubuntu: 24.04: Fix missing `unminimize` script
tom-reinders Oct 17, 2024
e23ed3a
workflows: ubuntu-images: Do not fail the workflow early
tom-reinders Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ubuntu-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
strategy:
matrix:
release: ['16.04', '18.04', '20.04', '22.04', '23.10', '24.04']
fail-fast: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travier opitions on fail-fast? I'm torn :)

Copy link
Author

@tom-reinders tom-reinders Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this had been set like i do now only 24.04 would have fail and the rest not, now they all got cancelled for no reason at all.

Why break all break all releases if only 1 is broken?

It's also better for if there where 2 releases to fail because if not set then we would only notice it after we fixed the first.

In this setup of the GitHub action I don't know any reasons against setting this setting.
Do you have any reasons?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does make sense :)


runs-on: ubuntu-latest
steps:
Expand Down
7 changes: 4 additions & 3 deletions images/ubuntu/24.04/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ RUN sed -Ei 's/^(hosts:.*)(\<files\>)\s*(.*)/\1\2 myhostname \3/' /etc/nsswitch.
# Install ubuntu-minimal & ubuntu-standard
# Install extra packages as well as libnss-myhostname
COPY extra-packages /
RUN sed -Ei '/apt-get (update|upgrade)/s/^/#/' /usr/local/sbin/unminimize && \
apt-get update && \
yes | /usr/local/sbin/unminimize && \
RUN apt-get update && \
DEBIAN_FRONTEND=noninteractive apt-get -y install unminimize && \
sed -Ei '/apt-get (update|upgrade)/s/^/#/' /usr/bin/unminimize && \
yes | /usr/bin/unminimize && \
DEBIAN_FRONTEND=noninteractive apt-get -y install \
ubuntu-minimal ubuntu-standard \
libnss-myhostname \
Expand Down