Replace /usr/local/sbin/unminimize with unminimize in apt
#1567
Conversation
tom-reinders
requested review from
Jmennius,
HarryMichal and
debarshiray
as code owners
tom-reinders
force-pushed
the
fix-1566
branch
from
2adc264
to
d3b5dbd
Compare
tom-reinders
force-pushed
the
fix-1566
branch
from
eeaad4c
to
180b56c
Compare
|
Build failed. ✔️ unit-test SUCCESS in 5m 46s |
|
Build failed. ✔️ unit-test SUCCESS in 5m 49s |
| @@ -37,6 +37,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| release: ['16.04', '18.04', '20.04', '22.04', '23.10', '24.04'] | |||
| fail-fast: false | |||
There was a problem hiding this comment.
@travier opitions on fail-fast? I'm torn :)
There was a problem hiding this comment.
If this had been set like i do now only 24.04 would have fail and the rest not, now they all got cancelled for no reason at all.
Why break all break all releases if only 1 is broken?
It's also better for if there where 2 releases to fail because if not set then we would only notice it after we fixed the first.
In this setup of the GitHub action I don't know any reasons against setting this setting.
Do you have any reasons?
There was a problem hiding this comment.
Yeah, it does make sense :)
| @@ -37,6 +37,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| release: ['16.04', '18.04', '20.04', '22.04', '23.10', '24.04'] | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Yeah, it does make sense :)
`unminimize` has been moved to a dedicated package: https://discourse.ubuntu.com/t/oracular-oriole-release-notes/44878#unminimize-33 Fixes: containers#1566 Signed-off-by: Tom Reinders <[email protected]>
...if one of the releases fails, let other releases build and publish. Signed-off-by: Tom Reinders <[email protected]>
|
I've reworded and squashed commits, removed |
|
Hmm, looking at how Github notifies about scheduled workflows...
So if I want to receive notification I should be the one to be the last editor or enabled of the workflow... this is hilarious, there is no way to set it as a configuration. |
Fixes #1566
/usr/local/sbin/unminimizehas been remove and has been replaced withunminimizein aptdocker-library/official-images#17708 (comment)
https://discourse.ubuntu.com/t/oracular-oriole-release-notes/44878#unminimize-33