Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: verify that code generation works and results match #113

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ci: verify that code generation works and results match #113

merged 1 commit into from
Oct 1, 2024

Conversation

askervin
Copy link
Contributor

No description provided.

klihub
klihub reviewed Sep 27, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@askervin askervin force-pushed the 5XD_ci_check_generated branch 2 times, most recently from e8d657b to 252bf67 Compare September 27, 2024 13:24
@klihub klihub self-requested a review September 27, 2024 13:36
klihub
klihub reviewed Sep 27, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@askervin askervin force-pushed the 5XD_ci_check_generated branch 2 times, most recently from d534b27 to 64e8a0a Compare September 27, 2024 14:37
@klihub klihub self-requested a review September 27, 2024 16:12
klihub
klihub approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, Antti ! LGTM.

mikebrow
mikebrow approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit when looking at the makefile the new target isn't as obvious as it is when looking at the protoc force regen test.. see proposed de minimis edit

Makefile Outdated Show resolved Hide resolved
@askervin askervin force-pushed the 5XD_ci_check_generated branch 2 times, most recently from 41b95ac to 505243a Compare October 1, 2024 06:36
@klihub klihub self-requested a review October 1, 2024 07:22
klihub
klihub approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub requested a review from mikebrow October 1, 2024 07:23
mikebrow
mikebrow approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@mikebrow mikebrow merged commit 7b3bcee into containerd:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid Awaiting requested review from fuweid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askervin @klihub @mikebrow