Skip to content

Commit

Permalink
ci: verify that code generation works and results match
Browse files Browse the repository at this point in the history
Signed-off-by: Antti Kervinen <[email protected]>
  • Loading branch information
askervin committed Sep 27, 2024
1 parent 668be88 commit 64e8a0a
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
31 changes: 31 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,37 @@ jobs:
- run: |
make all
test-validate-repo:
needs: test-build
name: Check validate-repo
runs-on: ubuntu-22.04
timeout-minutes: 5

steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.21.x

- name: Set env
shell: bash
run: |
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
- name: Install protoc and plugins
run: |
sudo make install-protoc
make install-protoc-dependencies install-ttrpc-plugin
- name: Force regeneration of protobuf files
run: |
touch pkg/api/api.proto
make all
- name: Validate files in git have not been changed
run: |
make validate-repo
linters:
name: Linters
runs-on: ${{ matrix.os }}
Expand Down
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ vet:
golangci-lint:
$(Q)$(GOLANG_CILINT) run

validate-repo:
$(Q)test -z "$$(git status --short | tee /dev/stderr)" || { \
echo "Repository is in invalid state."; \
echo "Please make sure to commit all changes, including generated files."; \
exit 1; \
}

#
# proto generation targets
#
Expand Down

0 comments on commit 64e8a0a

Please sign in to comment.