Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC-30955] update asynchttpclient #517

Open
wants to merge 3 commits into
base: 7.1.x
Choose a base branch
from
+5 −3
Open

[CC-30955] update asynchttpclient #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47e4bc1
update asynchttpclient
janjwerner-confluent Dec 11, 2024
0292154
update the duration type to reflect change in asynchttpclient
janjwerner-confluent Dec 12, 2024
f122447
use proper timeout unit s -> ms
janjwerner-confluent Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/test/java/io/confluent/rest/CustomInitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.Properties;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Consumer;
import java.time.Duration;
import javax.websocket.EndpointConfig;
import javax.websocket.OnOpen;
import javax.websocket.Session;
Expand Down Expand Up @@ -143,7 +144,7 @@ public void onError(Throwable t) {

WebSocket ws = Dsl.asyncHttpClient()
.prepareGet(uri + "/test")
.setRequestTimeout(10000)
.setRequestTimeout(Duration.ofMillis(10000))
.execute(wsHandler)
.get();

Expand Down
3 changes: 2 additions & 1 deletion core/src/test/java/io/confluent/rest/SaslTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
import java.util.Collections;
import java.util.Map;
import java.util.Properties;
import java.time.Duration;

import javax.security.auth.login.Configuration;
import javax.ws.rs.GET;
Expand Down Expand Up @@ -283,7 +284,7 @@ public void onError(Throwable t) {
}

WebSocket ws = requestBuilder
.setRequestTimeout(10000)
.setRequestTimeout(Duration.ofMillis(10000))
.execute(wsHandler)
.get();

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<apache.httpclient.version>4.5.13</apache.httpclient.version>
<confluent.maven.repo>https://packages.confluent.io/maven/</confluent.maven.repo>
<jersey.version>2.36</jersey.version>
<asynchttpclient.version>2.2.0</asynchttpclient.version>
<asynchttpclient.version>3.0.1</asynchttpclient.version>
<checkstyle.suppressions.location>checkstyle/suppressions.xml</checkstyle.suppressions.location>
<io.confluent.rest-utils.version>7.1.16-0</io.confluent.rest-utils.version>
</properties>
Expand Down