Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC-30955] update asynchttpclient #517

Open
wants to merge 3 commits into
base: 7.1.x
Choose a base branch
from

Conversation

janjwerner-confluent
Copy link
Member

@janjwerner-confluent janjwerner-confluent commented Dec 11, 2024

Fix for CVE-2024-53990

@janjwerner-confluent janjwerner-confluent requested review from a team as code owners December 11, 2024 19:42
Zhongyin-Zhang
Zhongyin-Zhang previously approved these changes Dec 11, 2024
Copy link
Member

@Zhongyin-Zhang Zhongyin-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trnguyencflt
Copy link
Member

@janjwerner-confluent look like the build failure is related to the change of asynchttpclient version, could you please have a look, thanks 👍

[INFO] ------------------------------------------------------------------------02:16
[INFO] BUILD FAILURE02:16
[INFO] ------------------------------------------------------------------------02:16
[INFO] Total time:  02:15 min02:16
[INFO] Finished at: 2024-12-11T19:47:51Z02:16
[INFO] ------------------------------------------------------------------------02:16
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project rest-utils: Compilation failure: Compilation failure: 02:16
[ERROR] /home/semaphore/rest-utils/core/src/test/java/io/confluent/rest/SaslTest.java:[286,28] incompatible types: int cannot be converted to java.time.Duration02:16
[ERROR] /home/semaphore/rest-utils/core/src/test/java/io/confluent/rest/CustomInitTest.java:[146,28] incompatible types: int cannot be converted to java.time.Duration

@@ -143,7 +144,7 @@ public void onError(Throwable t) {

WebSocket ws = Dsl.asyncHttpClient()
.prepareGet(uri + "/test")
.setRequestTimeout(10000)
.setRequestTimeout(Duration.ofSeconds(10000))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a bit odd, should it be Duration.ofMillis(10000)? Because 10000 seconds are quite long.

@janjwerner-confluent janjwerner-confluent changed the title update asynchttpclient [CC-30955] update asynchttpclient Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants