-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CC-30955] update asynchttpclient #517
base: 7.1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@janjwerner-confluent look like the build failure is related to the change of asynchttpclient version, could you please have a look, thanks 👍
|
0292154
@@ -143,7 +144,7 @@ public void onError(Throwable t) { | |||
|
|||
WebSocket ws = Dsl.asyncHttpClient() | |||
.prepareGet(uri + "/test") | |||
.setRequestTimeout(10000) | |||
.setRequestTimeout(Duration.ofSeconds(10000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems a bit odd, should it be Duration.ofMillis(10000)
? Because 10000 seconds are quite long.
Fix for CVE-2024-53990