-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linux ppc64le #255
base: main
Are you sure you want to change the base?
Enable linux ppc64le #255
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks Jeongseok! 🙏 This looks like a good set of changes For the remaining CI jobs, think you will need to accept the ToS, which is pretty similar to other CIs ToS. This amounts to making a PR like this one adding your username to the list like so: Quansight/open-gpu-server#37 Once that is done we can see how CI progresses |
Great, thank you! 🙏 Asked Jaime to take a look as he typically reviews those 🙂 Am wondering if it is worth grabbing this workaround for NumPy builds in PyTorch: #254 (comment) The reason being we discovered ARM builds likely need that workaround. So think if that is true, it is probably also true for Power What do you think? Should add it is ok if you prefer to wait and see how CI goes first. We do now cover that in the test suite after having seen it before. So we will know either way if it is an issue pytorch-cpu-feedstock/recipe/meta.yaml Line 332 in 6dd85b3
|
I suggest adding back the early failure I am suggesting in: you might be faster at debuging what is going on, but that early test might be more than adequate |
Agree that sounds like a good plan. Thanks for putting it together Mark! 🙏 Commented over there 🙂 |
@conda-forge-admin, please rerender |
@conda-forge-admin, please restart ci |
please add:
to the top level build section if you are not ready yet to get the GPU enabled, please add an other line with:
and rerender |
@conda-forge-admin please rerender |
sorry about that, lets just skip everything except for ppc64le for now and then re-optimize the builds. |
Sure, feel free to do anything that makes sense to you or take over this PR. Thank you for helping! |
no i'm struggling with aarch64 already. i won't be able to take over, but this feedstock just hogs the CIs, then you end up building linux64 for 6 hours instead of running ppc64le which you want! |
maybe try rerendering locally, rerendering with cuda is always slow... |
@conda-forge-admin please rerender |
@conda-forge-admin please rerender One more rerender. I am allowed to the GPU runners, but you can simply use azure until the 6 hour timeout is hit. |
@conda-forge-admin please rerender sigh... always one more thing to rerender |
alright, you have the CIs now. happy tuning! |
i'm also assuming that you have access to a powerful linux machine with docker. To build locally
and it should walk you through things. |
While the builds have started, I have a feeling you are hitting the same problems I am with aarch See: Depending on what you are trying to prove at this stage (numpy detection vs others), you might want to pull in my patch that causes this to fail loudly. |
skip: true # [py!=310] | ||
skip: true # [osx] | ||
skip: true # [aarch64] | ||
skip: true # [linux64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip: true # [linux64] | |
skip: true # [linux64] | |
skip: true # [cuda_compiler_version != "None"] |
While you are hitting failures in the CPU build, it would be nice to just cancel the cuda builds too ;)
356a868
to
9396891
Compare
…nda-forge-pinning 2024.12.02.17.28.06
9396891
to
4880c02
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12130811287. Examine the logs at this URL for more detail. |
Happy New Year! 🥳 Noticed some conflicts crept in due to recent merges To fix conflicts, would recommend...
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)